Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable asserts for checking non-empty nulls #8184

Closed
razajafri opened this issue Apr 25, 2023 · 1 comment · Fixed by #8517
Closed

Enable asserts for checking non-empty nulls #8184

razajafri opened this issue Apr 25, 2023 · 1 comment · Fixed by #8517
Assignees
@razajafri
Labels
task Work required that improves the product but is not user facing

Comments

@razajafri
Copy link
Collaborator

As part of #8183 we disabled asserts for checking non-empty nulls. This is a follow-on issue to have a proper fix where we only disable the assertions where it's ok for us to have non-empty nulls and no where else
@razajafri razajafri added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 25, 2023
@razajafri razajafri self-assigned this Apr 25, 2023
@razajafri razajafri mentioned this issue Apr 25, 2023
Merged
@revans2
Copy link
Collaborator

revans2 commented Apr 26, 2023

To be clear the only place where it is okay to have non-empty nulls should be in tests that verify that we do the right thing with non-empty nulls.

@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label May 2, 2023
@razajafri razajafri mentioned this issue Jun 6, 2023
Merged
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Disable asserts for non-empty nulls (#8183)" [databricks] razajafri/spark-rapids
4 participants
@revans2 @mattahrens @sameerz @razajafri