Make RapidsBufferHandle AutoCloseable to prevent extra attempts to remove buffers #7548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove buffers Signed-off-by: Alessandro Bellina <[email protected]>
|
build |
jlowe
approved these changes
Jan 19, 2023
gerashegalov
approved these changes
Jan 19, 2023
sameerz
added
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina [email protected]
This is follow on work from #7512 but the issue was there before my pr was merged because spillable columnar batch could be closed on a finalizer in the broadcast code, attempting to close some buffer that doesn't exist anymore (because this races with the catalog cleanup logic)
This centralizes the close to the
RapidsBufferHandle. Note, I made no attempts to invalidate theidin the handle, or throw from the other methods for this handle. I figure we can add that if we see issues or reviewers find that we need to be really strict here and make the handle throw on use.