Adds RapidsBufferHandle as an indirection layer to RapidsBufferId #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
Signed-off-by: Alessandro Bellina <[email protected]>
abellina
force-pushed
the
spill/rapids_buffer_handle
branch
from
ffdf9ba to
e190406
Compare
|
build |
revans2
reviewed
Jan 13, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Show resolved
Hide resolved
razajafri
reviewed
Jan 13, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Show resolved
Hide resolved
|
build |
|
I just made a simplification to the design here and will push a commit (and if we are ok with it I'll update the description). Sprinkled throughout the test code I had This means I can remove a bunch of makeNewHandle boilerplate code. |
|
build |
|
build |
|
build |
|
build |
1 similar comment
|
build |
|
build |
revans2
previously approved these changes
Jan 18, 2023
| @@ -217,6 +396,10 @@ object RapidsBufferCatalog extends Logging with Arm { | |||
| } | |||
|
|
|||
| private def closeImpl(): Unit = { | |||
| if (singleton != null) { | |||
| singleton.close() | |||
There was a problem hiding this comment.
nit: I am confused by this. singleton is a val and it is set at startup. When will it ever be null?
There was a problem hiding this comment.
a good eye, I'll clean this up
jlowe
reviewed
Jan 18, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/ShuffleBufferCatalog.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/SpillableColumnarBatch.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastExchangeExec.scala
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleClientSuite.scala
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleTestHelper.scala
Show resolved
Hide resolved
|
build |
jlowe
approved these changes
Jan 18, 2023
|
build |
1 similar comment
|
build |
sameerz
added
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #6864
This PR adds a
RapidsBufferHandlewhich is to be used outside of the spill framework. What I am going for here is that stores only work withRapidsBufferIdand the catalogs only deal withRapidsBufferHandleand the mapping between them. TheRapidsBufferCatalogowns these handles.What this PR allows us to do but is not included here is the ability to have multiple handles to a buffer. In a subsequent PR, we will detect a collision and return a new handle, but keep the original
RapidsBufferand its id.I am posting this to run through CI mostly and to get some feedback. I need to a bit more manual testing.