Revert Null Join Filter #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVIDIA#594)" This reverts commit df00904.
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
I reran all of the tpc-ds tests and scale factor 1 and they all pass now. |
jlowe
approved these changes
Sep 11, 2020
abellina
approved these changes
Sep 11, 2020
I plan on putting this back in again for 0.3 once I have more then an hour to try and figure out what is happening. |
|
Actually now that this is getting punted to 0.3 and thus cudf-0.16, I wonder if we should focus our efforts on implementing the fix in libcudf as mentioned by rapidsai/cudf#6052 (comment). I think that would be the preferred solution from a performance and code complexity perspective. |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Revert "Filter nulls from joins where possible to improve performance. (NVIDIA#594)" This reverts commit df00904. * Fix tests to run Signed-off-by: Robert (Bobby) Evans <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Revert "Filter nulls from joins where possible to improve performance. (NVIDIA#594)" This reverts commit df00904. * Fix tests to run Signed-off-by: Robert (Bobby) Evans <[email protected]>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.12 to branch-23.02 [skip ci] [bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #744
This reverts #594
It appears that I missed something when I put in the original change and I cannot think of what I did wrong quickly, so I am going to revert this for 0.2 and reopen the original issue so I can try again in 0.3