Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TPC-DS query 6 now produces incorrect results. #744

Closed
revans2 opened this issue Sep 11, 2020 · 3 comments · Fixed by #745
Closed

[BUG] TPC-DS query 6 now produces incorrect results. #744

revans2 opened this issue Sep 11, 2020 · 3 comments · Fixed by #745
Labels
bug Something isn't working P0 Must have for release

Comments

@revans2
Copy link
Collaborator

revans2 commented Sep 11, 2020

Describe the bug
When I run TPC-DS query 6 on scale factor 1 I get an incorrect result relative to the CPU. The GPU version is missing a null state count.

Steps/Code to reproduce bug

./run_pyspark_from_build.sh -k 'tpcds[q6]' --tpcds_path=/home/roberte/src/data/tpcds/SF1_parquet/ --tpcds_format=parquet

Expected behavior
It should pass, but it fails.

Environment details (please complete the following information)
0.2 pre-release

Additional context
I had to make some minor changes to get this to work because the java/scala APIs changed a bit and things needed to be updated. I'll add in a patch.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify P0 Must have for release labels Sep 11, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Sep 11, 2020

diff.patch.txt

@revans2
Copy link
Collaborator Author

revans2 commented Sep 11, 2020

Looks like df00904 introduced the issue according to git bisect

@revans2
Copy link
Collaborator Author

revans2 commented Sep 11, 2020

I just verified that reverting the above change fixes the regressions. I will try to come up with a patch that fixes the issue instead of removing it, but if I cannot get a patch ready in under an hour I'll put up the revert patch.

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Sep 11, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
…IDIA#744)

Signed-off-by: spark-rapids automation <[email protected]>

Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants