Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scaladoc on an internal method to avoid warning during build #2534

Merged
merged 2 commits into from
May 28, 2021
Merged

Remove scaladoc on an internal method to avoid warning during build #2534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5208cbb
Internal method doesn't need scaladocs
razajafri May 28, 2021
f91ae69
added asterisk
razajafri May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,14 +724,10 @@ trait ParquetPartitionReaderBase extends Logging with Arm with ScanWithMetrics
* @return
*/
private def convertDecimal64ToDecimal32Wrapper(cv: ColumnVector, precision: Int): ColumnVector = {
/**
* This method returns a ColumnView that should be copied out to a ColumnVector before closing
* the `toClose` views otherwise it will close the returned view and it's children as well.
*
* @param cv ColumnView to be checked if it has Decimal32 values stored as Decimal64
* @param precision precision list of all the Decimal columns in this ColumnVector
* @param toClose The ColumnViews to be closed after this method is done. This will also
* contain the returned view
/*
* 'convertDecimal64ToDecimal32' method returns a ColumnView that should be copied out to a
* ColumnVector before closing the `toClose` views otherwise it will close the returned view
* and it's children as well.
*/
def convertDecimal64ToDecimal32(
cv: ColumnView,
Expand Down