Remove scaladoc on an internal method to avoid warning during build #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <[email protected]>
razajafri
changed the title
|
build |
jlowe
reviewed
May 28, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
Outdated
Show resolved
Hide resolved
jlowe
changed the title
Signed-off-by: Raza Jafri <[email protected]>
jlowe
approved these changes
May 28, 2021
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…VIDIA#2534) * Internal method doesn't need scaladocs Signed-off-by: Raza Jafri <[email protected]> * added asterisk Signed-off-by: Raza Jafri <[email protected]> Co-authored-by: Raza Jafri <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…VIDIA#2534) * Internal method doesn't need scaladocs Signed-off-by: Raza Jafri <[email protected]> * added asterisk Signed-off-by: Raza Jafri <[email protected]> Co-authored-by: Raza Jafri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal method to a private method doesn't need scaladocs. I have kept the comment as a multi-line comment.
I couldn't take this function up one level because we created the wrapper just so no one can misuse this function accidentally.
fixes #2495
Signed-off-by: Raza Jafri [email protected]