Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JSON Scan and from_json by default #11753

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Enable JSON Scan and from_json by default #11753

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fce8d0b
Enable JSON Scan and from_json by default
revans2 Nov 22, 2024
804db73
Merge branch 'branch-24.12' into from_json_on_by_default
revans2 Nov 25, 2024
b437089
Review comments
revans2 Nov 25, 2024
67bf5cf
Update docs/compatibility.md
ttnghia Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ try to call out which releases we offer different results for. JSON parsing is e
except for date and timestamp types where we still have work to complete. If you wish to disable
JSON Scan you can set `spark.rapids.sql.format.json.enabled` or
`spark.rapids.sql.format.json.read.enabled` to false. To disable `from_json` you can set
`spark.rapids.sql.expression.StructsToJson` to false.
`spark.rapids.sql.expression.JsonToStructs` to false.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Generally I prefer to have someone post a change request instead of pushing to my PR directly. That is so that I can keep my internal development branch in sync with what is in the PR.


### Limits

Expand Down