Enable JSON Scan and from_json by default #11753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
Note that this depends on: |
ttnghia
reviewed
Nov 23, 2024
ttnghia
reviewed
Nov 23, 2024
docs/compatibility.md
Outdated
| Spark supports parsing decimal types either formatted as floating point number or integral numbers, even if it is | ||
| in a quoted string. If it is in a quoted string the local of the JVM is used to determine the number format. | ||
| If the local is not for the `US`, which is the default we will fall back to the CPU because we do not currently | ||
| parse those numbers correctly. The `US` format removes all commas ',' from the string. |
There was a problem hiding this comment.
Need to clarify this, otherwise this can be misunderstood as removing commas from any string either quoted or unquoted.
Suggested change
| parse those numbers correctly. The `US` format removes all commas ',' from the string. | |
| parse those numbers correctly. The `US` format removes all commas ',' from the quoted string. |
ttnghia
reviewed
Nov 23, 2024
ttnghia
reviewed
Nov 23, 2024
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
@ttnghia please take another look |
ttnghia
reviewed
Nov 25, 2024
ttnghia
approved these changes
Nov 25, 2024
|
build |
revans2
commented
Nov 25, 2024
| @@ -323,7 +323,7 @@ try to call out which releases we offer different results for. JSON parsing is e | |||
| except for date and timestamp types where we still have work to complete. If you wish to disable | |||
| JSON Scan you can set `spark.rapids.sql.format.json.enabled` or | |||
| `spark.rapids.sql.format.json.read.enabled` to false. To disable `from_json` you can set | |||
| `spark.rapids.sql.expression.StructsToJson` to false. | |||
| `spark.rapids.sql.expression.JsonToStructs` to false. | |||
There was a problem hiding this comment.
Thanks for the fix. Generally I prefer to have someone post a change request instead of pushing to my PR directly. That is so that I can keep my internal development branch in sync with what is in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #11630
Note that @ttnghia did a lot of work on MAP support so we are enabling that by default too.