-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding row/column tests and benchmarks along with a benchmark/test building framework #331
Adding row/column tests and benchmarks along with a benchmark/test building framework #331
Conversation
Signed-off-by: Mike Wilson <[email protected]>
…ts_and_benchmarks
Signed-off-by: Mike Wilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contributing guide needs to be updated with instructions on how to use the new build features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
build |
Build needs more work
|
Yes, this turned out to be a bug in the CMake Makefile Generator. I have a workaround and will update with it soon. |
build |
The workaround isn't working so well. Talking with Robert Maynard about it. |
build |
This PR adds c++ tests and benchmarks to
spark-rapids-jni
. The tests and benchmarks link in the helpers from cudf, so a test can be lifted directly from cudf or written in the same style as a cudf test. The benchmarks only support nvbench, as that is the preferred benchmarking tool.To build with tests, pass
-DBUILD_TESTS
to the command line for the build and to build benchmarks, pass-DBUILD_BENCHMARKS
. The test library used from cudf is built any time cudf is built, so no changes are necessary for that build. The benchmark library requires that benchmarks are built, so this is plumbed down through thepom.xml
andbuild-libcudf.xml
if the user selects benchmark building.The change includes a new script
build/run-in-docker
that will run an executable in the same container environment that was used to buildspark-rapids-jni
. This script also allows an empty argument list and will drop the user into an interactive shell inside the container. This isn't a requirement, but ensures the same environment in the case the user is unable or unwilling to match the build environment.I had to copy the 22.08 version of
row_conversion.cu
so the tests would properly work, but it is not quite ready to move to this repository yet.Adding automatic running of tests after build was suggested as a feature, but left for another PR. I have added issue #330 to track it.