Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Allow building and running all tests in a single command #330

Closed
hyperbolic2346 opened this issue Jun 16, 2022 · 2 comments
Closed

[FEA] Allow building and running all tests in a single command #330

hyperbolic2346 opened this issue Jun 16, 2022 · 2 comments
Labels
build

Comments

@hyperbolic2346
Copy link
Collaborator

Now that c++ tests are being added to spark-rapids-jni, it would be nice to have a single script to run that would build the library, tests, and run the tests. This could be leveraged in CI.
@hyperbolic2346 hyperbolic2346 mentioned this issue Jun 16, 2022
Merged
@jlowe
Copy link
Member

jlowe commented Jun 16, 2022

Rather than a script, I would rather see this be an option controllable via the normal Maven build, either via a property that is set or a profile that is enabled. Compiling and running tests is a normal part of building, and I'd rather this not be a separate step from the build.

@jlowe jlowe added the build label Jun 16, 2022
@jlowe
Copy link
Member

jlowe commented Dec 11, 2024

Fixed by #389

@jlowe jlowe closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlowe @hyperbolic2346