Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor native build to a shell script #2677

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Refactor native build to a shell script #2677

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10820ee
Refactor native build to a shell script
jlowe Dec 9, 2024
7da0d05
Review comments
jlowe Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions build/buildcpp.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,37 @@
# Script to build native code in cudf and spark-rapids-jni
#

set -ex
set -e

if [[ $FROM_MAVEN == "true" ]]; then
echo "Building native libraries. To rerun outside Maven enter the build environment via

$ ./build/run-in-docker

then run

$ REUSE_ENV=true $0
"
fi

# Disable items on arm64 due to missing dependencies in the CUDA toolkit
if [ "$(uname -m)" == "aarch64" ]; then
USE_GDS="OFF" # cuFile RDMA libraries are missing
BUILD_FAULTINJ="OFF" # libcupti_static.a is missing
fi

# Environment variables to control the build
PROJECT_BASE_DIR=${PROJECT_BASE_DIR:-$(realpath $(dirname $0)/..)}
PROJECT_BUILD_DIR=${PROJECT_BUILD_DIR:-$PROJECT_BASE_DIR/target}
if [[ "$REUSE_ENV" != "true" ]]; then
echo "
BUILD_BENCHMARKS=${BUILD_BENCHMARKS:-ON}
BUILD_CUDF_BENCHMARKS=${BUILD_CUDF_BENCHMARKS:-OFF}
BUILD_CUDF_TESTS=${BUILD_CUDF_TESTS:-OFF}
BUILD_FAULTINJ=${BUILD_FAULTINJ:-ON}
BUILD_PROFILER=${BUILD_PROFILER:-ON}
BUILD_TESTS=${BUILD_TESTS:-ON}
export CMAKE_GENERATOR=${CMAKE_GENERATOR:-Ninja}
CPP_PARALLEL_LEVEL=${CPP_PARALLEL_LEVEL:-10}
CUDF_BUILD_TYPE=${CUDF_BUILD_TYPE:-Release}
CUDF_PATH=${CUDF_PATH:-$PROJECT_BASE_DIR/thirdparty/cudf}
Expand All @@ -43,7 +63,10 @@ LIBCUDF_INSTALL_PATH=${LIBCUDF_INSTALL_PATH:-$PROJECT_BUILD_DIR/libcudf-install}
LIBCUDFJNI_BUILD_PATH=${LIBCUDFJNI_BUILD_PATH:-$PROJECT_BUILD_DIR/libcudfjni}
SPARK_JNI_BUILD_PATH=${SPARK_JNI_BUILD_PATH:-$PROJECT_BUILD_DIR/jni/cmake-build}
RMM_LOGGING_LEVEL=${RMM_LOGGING_LEVEL:-OFF}
USE_GDS=${USE_GDS:-OFF}
USE_GDS=${USE_GDS:-OFF}" > "$PROJECT_BUILD_DIR/buildcpp-env.sh"
fi

source "$PROJECT_BUILD_DIR/buildcpp-env.sh"

#
# libcudf build
Expand All @@ -53,6 +76,7 @@ cd "$LIBCUDF_BUILD_PATH"

# Skip explicit cudf cmake configuration if it appears it has already configured
if [[ $LIBCUDF_BUILD_CONFIGURE == true || ! -f $LIBCUDF_BUILD_PATH/CMakeCache.txt ]]; then
echo "Configuring cudf native libs"
cmake "$CUDF_PATH/cpp" \
-DBUILD_BENCHMARKS="$BUILD_CUDF_BENCHMARKS" \
-DBUILD_SHARED_LIBS=OFF \
Expand All @@ -70,13 +94,15 @@ if [[ $LIBCUDF_BUILD_CONFIGURE == true || ! -f $LIBCUDF_BUILD_PATH/CMakeCache.tx
-DRMM_LOGGING_LEVEL="$RMM_LOGGING_LEVEL" \
-C="$CUDF_PIN_PATH/setup.cmake"
fi
echo "Building cudf native libs"
cmake --build "$LIBCUDF_BUILD_PATH" --target install "-j$CPP_PARALLEL_LEVEL"

#
# libcudfjni build
#
mkdir -p "$LIBCUDFJNI_BUILD_PATH"
cd "$LIBCUDFJNI_BUILD_PATH"
echo "Configuring cudfjni native libs"
CUDF_CPP_BUILD_DIR="$LIBCUDF_BUILD_PATH" CUDF_ROOT="$CUDF_PATH" cmake \
"$CUDF_PATH/java/src/main/native" \
-DBUILD_SHARED_LIBS=OFF \
Expand All @@ -89,13 +115,15 @@ CUDF_CPP_BUILD_DIR="$LIBCUDF_BUILD_PATH" CUDF_ROOT="$CUDF_PATH" cmake \
-DRMM_LOGGING_LEVEL="$RMM_LOGGING_LEVEL" \
-DUSE_GDS="$USE_GDS" \
-C="$CUDF_PIN_PATH/setup.cmake"
echo "Building cudfjni native libs"
cmake --build "$LIBCUDFJNI_BUILD_PATH" "-j$CPP_PARALLEL_LEVEL"

#
# sparkjni build
#
mkdir -p "$SPARK_JNI_BUILD_PATH"
cd "$SPARK_JNI_BUILD_PATH"
echo "Configuring spark-rapids-jni native libs"
CUDF_CPP_BUILD_DIR="$LIBCUDF_BUILD_PATH" \
CUDF_ROOT="$CUDF_PATH" \
CUDF_INSTALL_DIR="$LIBCUDF_INSTALL_PATH" \
Expand All @@ -112,4 +140,5 @@ CUDF_CPP_BUILD_DIR="$LIBCUDF_BUILD_PATH" \
-DRMM_LOGGING_LEVEL="$RMM_LOGGING_LEVEL" \
-DUSE_GDS="$USE_GDS" \
-C="$CUDF_PIN_PATH/setup.cmake"
echo "Building spark-rapids-jni native libs"
cmake --build "$SPARK_JNI_BUILD_PATH" "-j$CPP_PARALLEL_LEVEL"
8 changes: 4 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,7 @@
<target>
<exec dir="${project.basedir}"
failonerror="true"
executable="bash">
<arg value="build/buildcpp.sh"/>
<env key="PROJECT_BASE_DIR" value="${project.basedir}"/>
<env key="PROJECT_BUILD_DIR" value="${project.build.directory}"/>
executable="build/buildcpp.sh">
<env key="BUILD_BENCHMARKS" value="${BUILD_BENCHMARKS}"/>
<env key="BUILD_CUDF_BENCHMARKS" value="${BUILD_CUDF_BENCHMARKS}"/>
<env key="BUILD_CUDF_TESTS" value="${BUILD_CUDF_TESTS}"/>
Expand All @@ -451,12 +448,15 @@
<env key="CUDF_PATH" value="${cudf.path}"/>
<env key="CUDF_PIN_PATH" value="${cudf.pin.path}"/>
<env key="CUDF_USE_PER_THREAD_DEFAULT_STREAM" value="${CUDF_USE_PER_THREAD_DEFAULT_STREAM}"/>
<env key="FROM_MAVEN" value="true"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

<env key="GPU_ARCHS" value="${GPU_ARCHS}"/>
<env key="LIBCUDF_BUILD_CONFIGURE" value="${libcudf.build.configure}"/>
<env key="LIBCUDF_BUILD_PATH" value="${libcudf.build.path}"/>
<env key="LIBCUDF_DEPENDENCY_MODE" value="${libcudf.dependency.mode}"/>
<env key="LIBCUDF_INSTALL_PATH" value="${libcudf.install.path}"/>
<env key="LIBCUDFJNI_BUILD_PATH" value="${libcudfjni.build.path}"/>
<env key="PROJECT_BASE_DIR" value="${project.basedir}"/>
<env key="PROJECT_BUILD_DIR" value="${project.build.directory}"/>
<env key="SPARK_JNI_BUILD_PATH" value="${native.build.path}"/>
<env key="RMM_LOGGING_LEVEL" value="${RMM_LOGGING_LEVEL}"/>
<env key="USE_GDS" value="${USE_GDS}"/>
Expand Down
Loading