Refactor native build to a shell script #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
|
build |
jihoonson
previously approved these changes
Dec 10, 2024
|
This LGTM mostly. Ideally I would like to be able to tell the external engineer a single command to rerun in the Docker container. I put forward my suggestions as a PR to your PR branch for consideration The idea is that we reproduce the native build with a single command after dropping into the build Docker container Run This instruction appears in the log, we can also document it in the dev documentation. |
|
build |
gerashegalov
approved these changes
Dec 11, 2024
| @@ -451,12 +448,15 @@ | |||
| <env key="CUDF_PATH" value="${cudf.path}"/> | |||
| <env key="CUDF_PIN_PATH" value="${cudf.pin.path}"/> | |||
| <env key="CUDF_USE_PER_THREAD_DEFAULT_STREAM" value="${CUDF_USE_PER_THREAD_DEFAULT_STREAM}"/> | |||
| <env key="FROM_MAVEN" value="true"/> | |||
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2598. Refactors the native build into a shell script capable of being run standalone. The shell script is configured to log its commands to make it easier to see in a buildlog how cmake is being invoked across the phases of the native build.