Prepare the arg to disable kvikIO remote IO #2583
Conversation
Signed-off-by: Peixin Li <[email protected]>
|
build |
| @@ -463,6 +463,7 @@ | |||
| <arg value="-DCUDF_USE_PER_THREAD_DEFAULT_STREAM=${CUDF_USE_PER_THREAD_DEFAULT_STREAM}" /> | |||
| <arg value="-DCUDF_LARGE_STRINGS_DISABLED=ON"/> | |||
| <arg value="-DKvikIO_REMOTE_SUPPORT=OFF"/> | |||
| <arg value="-DCUDF_KVIKIO_REMOTE_IO=OFF"/> | |||
There was a problem hiding this comment.
Maybe remove KvikIO_REMOTE_SUPPORT? Since CUDF_KVIKIO_REMOTE_IO disables it in rapidsai/cudf#17291.
There was a problem hiding this comment.
this is for preemptive change for submodule sync update later, current cudf ref in JNI repo (for CI like premerge) still requires this flag until rapidsai/cudf#17291 is merged
merge this to re-enable submodule-sync pipeline, so it could work well whenever the cudf merge is fixed, we can do a post-cleanup for KvikIO_REMOTE_SUPPORT
|
Going to merge this one to re-enable auto submodule sync up, lets remove the |
We won't be able to run submodule sync until rapidsai/cudf#17291 merged in. That is why I suggested to remove |
I mean I want to re-enable the submodule sync up pipeline (not to pass the build), to make it automatically catch the change later. so we do not need to keep our eyes on it. Otherwise, there must be a human to monitor the status of the cudf fix and then merge required commits manually |
part of #2581
prepare the arg to help the submodule sync pipeline work correctly after rapidsai/cudf#17291