Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faultinj build error after spdlog/fmt upgrade #1608

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Dec 1, 2023

Resolves #1607. Recently cudf upgraded spdlog/fmt to a new version, and it now requires explicit formatting of enums or a compile error is generated. This updates the faultinj logging to allow the necessary enums to be logged and also updates the cudf submodule to the latest on branch-24.02 that picks up the spdlog/fmt dependency upgrade.

@jlowe jlowe added the build label Dec 1, 2023
@jlowe jlowe requested a review from gerashegalov December 1, 2023 16:47
@jlowe jlowe self-assigned this Dec 1, 2023
@jlowe
Copy link
Member Author

jlowe commented Dec 1, 2023

build

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlowe jlowe merged commit 9c3c7a6 into NVIDIA:branch-24.02 Dec 1, 2023
4 checks passed
@jlowe jlowe deleted the fix-build branch December 1, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants