Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] faultinj is logging enums through spdlog which is deprecated #955

Closed
revans2 opened this issue Feb 16, 2023 · 1 comment
Closed

[BUG] faultinj is logging enums through spdlog which is deprecated #955

revans2 opened this issue Feb 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 16, 2023

Describe the bug
When compiling spark rapids JNI we now get a lot of warnings about something that is deprecated in the formatting.

[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/fmt/bundled/core.h: In substitution of 'template<class T, class Context> using mapped_type_constant = fmt::v9::detail::type_constant<decltype (fmt::v9::detail::arg_mapper<Context>().map(declval<const T&>())), typename Context::char_type> [with T = CUpti_CallbackDomain; Context = fmt::v9::basic_format_context<fmt::v9::appender, char>]':
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/fmt/bundled/core.h:1729:9:   required from 'constexpr long long unsigned int fmt::v9::detail::encode_types() [with Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; Arg = CUpti_CallbackDomain; Args = {const char*, int, int, int}]'
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/fmt/bundled/core.h:1885:105:   required from 'constexpr const long long unsigned int fmt::v9::format_arg_store<fmt::v9::basic_format_context<fmt::v9::appender, char>, CUpti_CallbackDomain, const char*, int, int, int>::desc'
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/fmt/bundled/core.h:1998:92:   required from 'constexpr fmt::v9::basic_format_args<Context>::basic_format_args(const fmt::v9::format_arg_store<Context, Args ...>&) [with Args = {CUpti_CallbackDomain, const char*, int, int, int}; Context = fmt::v9::basic_format_context<fmt::v9::appender, char>]'
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/logger.h:374:18:   required from 'void spdlog::logger::log_(spdlog::source_loc, spdlog::level::level_enum, spdlog::string_view_t, Args&& ...) [with Args = {CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&}; spdlog::string_view_t = fmt::v9::basic_string_view<char>]'
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/logger.h:90:1:   required from 'void spdlog::logger::log(spdlog::source_loc, spdlog::level::level_enum, fmt::v9::format_string<T ...>, Args&& ...) [with Args = {CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&}; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&>]'
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/logger.h:96:1:   required from 'void spdlog::logger::log(spdlog::level::level_enum, fmt::v9::format_string<T ...>, Args&& ...) [with Args = {CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&}; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&>]'
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/logger.h:146:1:   required from 'void spdlog::logger::trace(fmt::v9::format_string<T ...>, Args&& ...) [with Args = {CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&}; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&>]'
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/target/libcudf-install/include/spdlog/spdlog.h:149:1:   required from 'void spdlog::trace(fmt::v9::format_string<T ...>, Args&& ...) [with Args = {CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&}; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, CUpti_CallbackDomain&, const char*&, const int&, const int&, const int&>]'
[INFO]      [exec] /home/roberte/src/spark-rapids-jni/src/main/cpp/faultinj/faultinj.cu:260:195:   required from here

It looks like logging of enums is deprecated, and faultinj.cu is doing that on lines 260 and 395.

@revans2 revans2 added bug Something isn't working ? - Needs Triage labels Feb 16, 2023
@jlowe
Copy link
Member

jlowe commented Dec 23, 2024

Fixed by #1608

@jlowe jlowe closed this as completed Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants