Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cuda::stream_ref #413

Closed
wants to merge 3 commits into from

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Dec 21, 2023

Contributes to #331

Switch the cuco custom stream_ref implementations to cuda::stream_ref.

Depending on NVIDIA/cccl#1238 to fix the stream sync bug.

@PointKernel PointKernel added In Progress Currently a work in progress type: improvement Improvement / enhancement to an existing function labels Dec 21, 2023
@miscco
Copy link
Contributor

miscco commented Dec 22, 2023

@PointKernel thanks a lot for finding this. I am pretty sure that we cannot backport get the fix into the 2.3.x release.

Are you building against main or do we need to add fix to rapids-cmake?

@bdice for visibility

@PointKernel
Copy link
Member Author

@PointKernel thanks a lot for finding this. I am pretty sure that we cannot backport get the fix into the 2.3.x release.

@miscco That's fine. cuco doesn't have an intermediate need for this feature so we can wait.

Are you building against main or do we need to add fix to rapids-cmake?

Let me put this PR on hold and come back once the fix is ready. No need to rush.

@mfbalin
Copy link

mfbalin commented Jun 23, 2024

  1. Is there going to be progress on this PR?
  2. Are the users going to have to change their code after this is merged?

Thank you for developing this wonderful library. I make use of it as part of developing dgl.graphbolt.

@PointKernel
Copy link
Member Author

Thank you for developing this wonderful library. I make use of it as part of developing dgl.graphbolt.

@mfbalin thank you! Happy to hear that! 🎉

Is there going to be progress on this PR?

This work depends on rapidsai/rapids-cmake#631 and #502 and hopefully will be finished in 2 weeks

Are the users going to have to change their code after this is merged?

It's not a breaking change so far thus you should be fine. Will keep you posted here.

@PointKernel
Copy link
Member Author

@mfbalin Just FYI, this PR is surpassed by #525 and based on current tests it shouldn't break any existing cuco use cases.

@PointKernel PointKernel deleted the switch-cuda-stream-ref branch July 3, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress Currently a work in progress type: improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants