Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to cuda::stream_ref #331

Closed
sleeepyjack opened this issue Jul 10, 2023 · 2 comments · Fixed by #525
Closed

Switch to cuda::stream_ref #331

sleeepyjack opened this issue Jul 10, 2023 · 2 comments · Fixed by #525
Labels
P1: Should have Necessary but not critical type: feature request New feature request

Comments

@sleeepyjack
Copy link
Collaborator

sleeepyjack commented Jul 10, 2023 •
edited
Loading

cuco::stream_ref is a WAR and should be replaced with cuda::stream_ref.

cuda::stream_ref will be available in libcu++ v2.1.0, and we should get that version soon: rapidsai/rapids-cmake#399.

Originally posted by @sleeepyjack in #296 (comment)
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jul 10, 2023
@PointKernel PointKernel added type: feature request New feature request P1: Should have Necessary but not critical labels Jul 26, 2023
@bdice bdice mentioned this issue Sep 22, 2023
Merged
7 tasks
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this issue Oct 16, 2023
@bdice
Update libcudacxx to 2.1.0 (#464)
e73fef6 
This PR separates out the libcudacxx update from #399. I am proposing to update only libcudacxx to 2.1.0, and leave thrust/cub pinned at 1.17.2 until all of RAPIDS is ready to update. Then we can move forward with #399 next.

Separating the update for libcudacxx should allow RAPIDS to use some of the new features we want while giving more time to RAPIDS libraries to migrate to CCCL 2.1.0 (particularly for breaking changes in Thrust/CUB).

**Immediate benefits of bumping only libcudacxx to 2.1.0:**
- Enables migration to Thrust/CUB 2.1.0 to be done more incrementally, because we could merge PRs using `cuda::proclaim_return_type` into cudf/etc. which would reduce the amount of unmerged code we're maintaining in the "testing PRs" while waiting for all RAPIDS repos to be ready for Thrust/CUB 2.1.0.
- Unblocks work in rmm (rapidsai/rmm#1095) and quite a few planned changes for cuCollections (such as NVIDIA/cuCollections#332, NVIDIA/cuCollections#331, NVIDIA/cuCollections#289)

**Risk Assessment:**
This should be fairly low risk because libcudacxx 2.1.0 is similar to our current pinning of 1.9.1 -- the major version bump was meant to align with Thrust/CUB and isn't indicative of major breaking changes.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #464
@bdice bdice mentioned this issue Oct 16, 2023
Merged
sleeepyjack pushed a commit that referenced this issue Oct 16, 2023
@bdice
Update to rapids-cmake 23.12. (#385)
f9b9b00 
This updates cuCollections to rapids-cmake 23.12. This comes with
rapidsai/rapids-cmake#464, which updates
libcudacxx to 2.1.0. That should unblock several cuCollections issues
such as #332,
#331,
#289.
@jrhemstad jrhemstad removed this from CCCL Nov 15, 2023
@PointKernel
Copy link
Member

PointKernel commented Dec 21, 2023 •
edited
Loading

Updates: this is still an experimental feature that requires to define LIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE https://godbolt.org/z/jfWsjarTz

@PointKernel PointKernel mentioned this issue Dec 21, 2023
Closed
@miscco
Copy link
Contributor

miscco commented Dec 22, 2023

Updates: this is still an experimental feature that requires to define LIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE https://godbolt.org/z/jfWsjarTz

We will most definitely drop the experimental state for `cuda::stream_ref``in the immediate future

Anything within <memory_resource> will stay experimental for a bit longer

@gitbuda gitbuda mentioned this issue Apr 25, 2024
Draft
55 tasks
@PointKernel PointKernel mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1: Should have Necessary but not critical type: feature request New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace cuco stream ref with cuda::stream_ref PointKernel/cuCollections
3 participants
@sleeepyjack @miscco @PointKernel