Update to CCCL 2.2.0. #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
force-pushed
the
cccl-2.2.0
branch
2 times, most recently
from
ccb64ce to
c28ebbd
Compare
This was referenced Dec 7, 2023
rapids-bot bot
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Dec 8, 2023
I saw an error (below) and @robertmaynard helped me identify that this change was needed. I was building cuGraph ([this branch](rapidsai/cugraph#4052)) with rapids-cmake pointing to [this branch](NVIDIA/cuCollections#404) of cuCollections. ``` -- CPM: Adding package [email protected] (cccl-2.2.0) CMake Error at build/release/_deps/rapids-cmake-src/rapids-cmake/cmake/make_global.cmake:59 (set_target_properties): Attempt to promote imported target "CCCL::Thrust" to global scope (by setting IMPORTED_GLOBAL) which is not built in this directory. Call Stack (most recent call first): build/release/_deps/rapids-cmake-src/rapids-cmake/cpm/find.cmake:189 (rapids_cmake_make_global) build/release/_deps/rapids-cmake-src/rapids-cmake/cpm/cccl.cmake:85 (rapids_cpm_find) build/release/_deps/cuco-src/cmake/thirdparty/get_cccl.cmake:18 (rapids_cpm_cccl) build/release/_deps/cuco-src/cmake/thirdparty/get_cccl.cmake:21 (find_and_configure_cccl) build/release/_deps/cuco-src/CMakeLists.txt:79 (include) ``` Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Robert Maynard (https://github.com/robertmaynard) URL: #500
PointKernel
pushed a commit
that referenced
this pull request
Dec 8, 2023
bdice
commented
Dec 8, 2023
robertmaynard
suggested changes
Dec 8, 2023
Co-authored-by: Robert Maynard <[email protected]>
robertmaynard
approved these changes
Dec 8, 2023
PointKernel
added
type: feature request
26 tasks
This was referenced Dec 18, 2023
sleeepyjack
approved these changes
Dec 18, 2023
This was referenced Dec 18, 2023
|
This should be ready to merge now. I'll create a follow-up PR to update rapids-cmake, and we'll merge that before starting the CCCL update for all of RAPIDS tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates cuCollections to use CCCL 2.2.0.