Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build errors when applying patches #493

Closed
sleeepyjack opened this issue Nov 22, 2023 · 1 comment
Closed

[BUG] Build errors when applying patches #493

sleeepyjack opened this issue Nov 22, 2023 · 1 comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@sleeepyjack
Copy link
Contributor

Describe the bug
We sometimes see the following error messages when configuring cuCollection through rapids-cmake:

-- CPM: Adding package cuco@ (dev)
-- CPM: cuco: Using local package [email protected]
-- CPM: cuco: Adding package [email protected] (2.1.0)
-- rapids-cmake [libcudacxx]: failed to apply diff install_rules.diffrapids-cmake [libcudacxx]: git diff output: error: patch failed: cmake/libcudacxxInstallRules.cmake:28
-- error: cmake/libcudacxxInstallRules.cmake: patch does not apply
-- error: patch failed: lib/cmake/libcudacxx/libcudacxx-header-search.cmake.in:1
-- error: lib/cmake/libcudacxx/libcudacxx-header-search.cmake.in: patch does not apply
-- 
-- rapids-cmake [libcudacxx]: applied diff reroot_support.diff to fix issue: 'Support conda-forge usage of CMake rerooting [https://github.com/NVIDIA/libcudacxx/pull/490], requires libcudacxx/install_rules.diff.'
-- rapids-cmake [libcudacxx]: applied diff proclaim_return_type_nv_exec_check_disable.diff to fix issue: 'Use pragma to disable execution checks in cuda::proclaim_return_type. [https://github.com/NVIDIA/libcudacxx/pull/448]'
-- rapids-cmake [libcudacxx]: applied diff memory_resource.diff to fix issue: 'Allow {async_}resource_ref to be constructible from a pointer. [https://github.com/NVIDIA/libcudacxx/pull/439]'
-- Configuring done (3.1s)
-- Generating done (0.0s)

The build still finishes successfully (see NVIDIA/cuCollections#397).

Steps/Code to reproduce bug
Build cuco

Expected behavior
Resolve the error or mark them as a warning instead.

Environment details (please complete the following information):
See NVIDIA/cuCollections#397

@sleeepyjack sleeepyjack added ? - Needs Triage Need team to review and classify bug Something isn't working labels Nov 22, 2023
@robertmaynard
Copy link
Contributor

Closing as NVIDIA/cuCollections#404 will remove the usage of the libcudacxx cpm module from cuCOllection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants