Distinct code path for key equality checks in packed_cas
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
type: bug
sleeepyjack
reviewed
Aug 21, 2023
PointKernel
added a commit
that referenced
this pull request
Sep 15, 2023
#356 introduces the `HasPayload` template boolean to distinguish code paths between map and set implementations thus the key input for base ref insert functions becomes redundant. This PR cleans up the base ref implementations by removing the key input and fixes a logical issue in #356: set doesn't have payload while map has.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where we previously used the whole slot content for map key comparisons in
packed_cas.