Add specialization for is_bitwise_comparable<cuco::pair>> #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleeepyjack
added
type: bug
jrhemstad
reviewed
Jul 18, 2023
| * @brief A pair of bitwise comparable types is also bitwise comparable | ||
| */ | ||
| template <typename First, typename Second> | ||
| struct is_bitwise_comparable<pair<First, Second>> |
There was a problem hiding this comment.
This is dangerous. If someone used a pair<char, int> as their key type, then it would be considered bitwise comparable, even though it would have padding bits.
There was a problem hiding this comment.
Right. would adding && sizeof(pair<First, Second>) == sizeof(First)+sizeof(Second) help?
There was a problem hiding this comment.
Remind me where we need to perform a bitwise equality on a pair?
There was a problem hiding this comment.
For a static_map, the value_type of the underlying open_addressing_impl is cuco::pair<Key, Value>.
|
@sleeepyjack This can be closed. The work is replaced by #356 since the root cause is that we shouldn't compare the whole slot for map key equality checks. |
PointKernel
added
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced with the new
open_addressing_implabstraction layer:Tl;dr, for the
packed_cascode path incuco::experimental::static_map::insert()we need tobitwise_compareacuco::pair. However, sincecuco::pairhas no unique object representation by default, it is notis_bitwise_comparable. Compilation fails with an assertion error here.This PR adds the missing specialization for
is_bitwise_comparable<cuco::pair>.