Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change cudax::uninitialized_buffer to own its memory resource with cudax::any_resource #2293

Merged
merged 33 commits into from
Aug 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
a9b62ef
Implement `any_resource` an owning wrapper around any resource
miscco Apr 24, 2024
e3821e7
Continue development of @miscco's `any_resource`
Aug 18, 2024
250a4f1
address review feedback
ericniebler Aug 22, 2024
4f4838e
Merge remote-tracking branch 'origin/main' into any_resource
ericniebler Aug 22, 2024
f004b7b
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] Aug 22, 2024
d88a33e
mark all deallocation functions as `noexcept`
ericniebler Aug 22, 2024
093ca52
fix some test failures
ericniebler Aug 22, 2024
c7ba5e7
more tests and bug fixes
ericniebler Aug 22, 2024
fb1203e
fix more build breaks
ericniebler Aug 22, 2024
ce70bc6
attempt to fix the cudax docs build
ericniebler Aug 22, 2024
ea19a83
exclude more symbols from the cudax docs
ericniebler Aug 22, 2024
7974cc0
more portability fixes and doxygen tweaks
ericniebler Aug 22, 2024
615a9b8
once more with feeling
ericniebler Aug 22, 2024
d36d8c8
getting pretty close now
ericniebler Aug 22, 2024
24ae3b6
fix broken test
ericniebler Aug 23, 2024
a797d0e
deduplicate `basic_any_resource` constructors to satisfy doxygen
ericniebler Aug 23, 2024
abecaa2
Merge remote-tracking branch 'origin/main' into any_resource
ericniebler Aug 23, 2024
e0d122a
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] Aug 23, 2024
78bd653
don't use `if constexpr` when compiling as c++14
ericniebler Aug 23, 2024
76850e2
more fixes for doxygen and c++14
ericniebler Aug 23, 2024
7db2090
back out a questionable addition of `noexcept`
ericniebler Aug 23, 2024
5170dae
molify msvc
ericniebler Aug 23, 2024
43d5426
accommodate integer size differences on msvc
ericniebler Aug 23, 2024
63ace20
eliminate shadow warning treated as error
ericniebler Aug 23, 2024
a6ee7e1
handle duplicate properties without triggering compiler warnings
ericniebler Aug 23, 2024
7e33a55
change `uninitialized_buffer` to own its memory resource using `any_r…
ericniebler Aug 26, 2024
f0c0644
Merge branch 'main' into wip-resource-owning-containers
miscco Aug 27, 2024
0aced7b
Use fully qualified name
miscco Aug 27, 2024
5115b08
Drop `__host__ __device__` from uninitialized_buffer
miscco Aug 27, 2024
f4d48c9
Revert "Drop `__host__ __device__` from uninitialized_buffer"
miscco Aug 27, 2024
9a80e17
Just do the cursed thing
miscco Aug 27, 2024
76a8674
Add missing include
miscco Aug 27, 2024
c3f6fc7
Adopt the doc string
miscco Aug 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adopt the doc string
miscco committed Aug 27, 2024

Verified

This commit was signed with the committer’s verified signature.
mcous Michael Cousins
commit c3f6fc7eb93342e882789c8c7ffde62a77cf82e9
Original file line number Diff line number Diff line change
@@ -171,7 +171,8 @@ class uninitialized_buffer
}

//! @rst
//! Returns a copy of the `any_resource` used to allocate the buffer
//! Returns a :ref:`resource_ref <libcudacxx-extended-api-memory-resources-resource-ref>` to the resource used to
//! allocate the buffer
//! @endrst
_CCCL_EXEC_CHECK_DISABLE
_CCCL_NODISCARD _CCCL_HOST_DEVICE _CUDA_VMR::resource_ref<_Properties...> resource() const noexcept
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericniebler I kept this as a resource_ref