-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change cudax::uninitialized_buffer
to own its memory resource with cudax::any_resource
#2293
Merged
miscco
merged 33 commits into
NVIDIA:main
from
ericniebler:wip-resource-owning-containers
Aug 28, 2024
Merged
change cudax::uninitialized_buffer
to own its memory resource with cudax::any_resource
#2293
miscco
merged 33 commits into
NVIDIA:main
from
ericniebler:wip-resource-owning-containers
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericniebler
added
the
CUDA Next
Feature intended for the Cuda Next experimental library
label
Aug 26, 2024
/ok to test |
ericniebler
added
the
pre-commit.ci autofix
apply pre-commit auto-fixes automatically
label
Aug 26, 2024
pre-commit-ci
bot
removed
the
pre-commit.ci autofix
apply pre-commit auto-fixes automatically
label
Aug 26, 2024
🟨 CI finished in 11h 25m: Pass: 99%/421 | Total: 2d 06h | Avg: 7m 48s | Max: 45m 02s | Hits: 92%/34002
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
CUB | |
+/- | Thrust |
+/- | CUDA Experimental |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 421)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
65 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
miscco
approved these changes
Aug 27, 2024
cudax/include/cuda/experimental/__container/uninitialized_buffer.h
Outdated
Show resolved
Hide resolved
cudax/include/cuda/experimental/__container/uninitialized_buffer.h
Outdated
Show resolved
Hide resolved
cudax/include/cuda/experimental/__container/uninitialized_buffer.h
Outdated
Show resolved
Hide resolved
/ok to test |
/ok to test |
🟨 CI finished in 1h 02m: Pass: 94%/56 | Total: 2h 57m | Avg: 3m 10s | Max: 11m 10s
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 56)
# | Runner |
---|---|
41 | linux-amd64-cpu16 |
9 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
/ok to test |
/ok to test |
/ok to test |
miscco
reviewed
Aug 27, 2024
//! @endrst | ||
_CCCL_EXEC_CHECK_DISABLE | ||
_CCCL_NODISCARD _CCCL_HOST_DEVICE _CUDA_VMR::resource_ref<_Properties...> resource() const noexcept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericniebler I kept this as a resource_ref
🟩 CI finished in 6h 35m: Pass: 100%/56 | Total: 2h 55m | Avg: 3m 08s | Max: 10m 45s | Hits: 78%/112
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 56)
# | Runner |
---|---|
41 | linux-amd64-cpu16 |
9 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
miscco
added a commit
to miscco/cccl
that referenced
this pull request
Aug 28, 2024
…`cudax::any_resource` (NVIDIA#2293) * Implement `any_resource` an owning wrapper around any resource Addresses NVIDIA#1426 * Continue development of @miscco's `any_resource` * address review feedback * [pre-commit.ci] auto code formatting * mark all deallocation functions as `noexcept` * fix some test failures * more tests and bug fixes * fix more build breaks * attempt to fix the cudax docs build * exclude more symbols from the cudax docs * more portability fixes and doxygen tweaks * once more with feeling * getting pretty close now * fix broken test * deduplicate `basic_any_resource` constructors to satisfy doxygen * [pre-commit.ci] auto code formatting * don't use `if constexpr` when compiling as c++14 * more fixes for doxygen and c++14 * back out a questionable addition of `noexcept` * molify msvc * accommodate integer size differences on msvc * eliminate shadow warning treated as error * handle duplicate properties without triggering compiler warnings * change `uninitialized_buffer` to own its memory resource using `any_resource` * Use fully qualified name * Drop `__host__ __device__` from uninitialized_buffer * Revert "Drop `__host__ __device__` from uninitialized_buffer" This reverts commit 5115b08. * Just do the cursed thing * Add missing include * Adopt the doc string --------- Co-authored-by: Michael Schellenberger Costa <[email protected]> Co-authored-by: anon <users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #2292 by changing
uninitialized_buffer
to store its memory resource in anany_resource
instead of merely referring to a memory resource withresource_ref
.NOTE: I will rebase this PR when #2266 lands. See [7e33a55] for the changes in this PR.
closes #2292
Change member
uninitialized_buffer::__mr_
fromresource_ref
toany_resource
. Be sure tostd::move
__mr_
when moving the owninguninitialized_buffer
.Checklist