Code

Callback PR Rev 2#597

Code

Closed

blisc wants to merge 113 commits intoNVIDIA:masterNVIDIA/NeMo:masterfrom blisc:U_callbacks_2blisc/NeMo:U_callbacks_2Copy head branch name to clipboard

+525-30

Commits

Commits on Mar 24, 2020

• Manual rebase of dev-module-composition on top of current master

  Show description for de587bd
  tkornuta-nvidia

  committed
  de587bd

• Adding neural graph examples

  Show description for 15b3b11
  tkornuta-nvidia

  committed
  15b3b11

• formatting fixes

  Show description for 2756a66
  tkornuta-nvidia

  committed
  2756a66

Commits on Apr 1, 2020

• new proposal

  Show description for 5bad9c9
  blisc

  committed
  5bad9c9

Commits on Apr 6, 2020

• Merge branch 'master' of github.com:NVIDIA/NeMo into fix-sign

  tkornuta-nvidia

  committed
  e26a906

• Merge branch 'fix-sign' of github.com:NVIDIA/NeMo into fix-sign

  tkornuta-nvidia

  committed
  85bb729

• format fix of Jason's example

  Show description for 0576ce7
  tkornuta-nvidia

  committed
  0576ce7

Commits on Apr 7, 2020

• Added modules recording, with retrieval of module name

  Show description for 3f1ac01
  tkornuta-nvidia

  committed
  3f1ac01

• keyerror comment

  Show description for a57b34d
  tkornuta-nvidia

  committed
  a57b34d

• Introduced name property of modules

  Show description for fc3deac
  tkornuta-nvidia

  committed
  fc3deac

• implemented NameRegistry basic functionality, test5 working, unit tests failing

  Show description for 5221fef
  tkornuta-nvidia

  committed
  5221fef

Commits on Apr 8, 2020

• example 5 working, ObjectRegistry finished, app_state moved to utils

  Show description for dd9af75
  tkornuta-nvidia

  committed
  dd9af75

• test app_state fixed

  Show description for ab35621
  tkornuta-nvidia

  committed
  ab35621

• TokenClassification self.name fix

  Show description for bbd3589
  tkornuta-nvidia

  committed
  bbd3589

• ObjectRegistry tests

  Show description for 56efff5
  tkornuta-nvidia

  committed
  56efff5

• cleanup of neural graphs class, NG manager inheriting from ObjectRegistry, starting to work on graph unit tests

  Show description for c838f13
  tkornuta-nvidia

  committed
  c838f13

• fixes to graph and manager, NeMo tests passing (locally)

  Show description for 1153001
  tkornuta-nvidia

  committed
  1153001

• code formatting

  Show description for 9df6568
  tkornuta-nvidia

  committed
  9df6568

Commits on Apr 9, 2020

• turning examples into unit/integration tests, small fixes here and there, work in progress

  Show description for 868ec8a
  tkornuta-nvidia

  committed
  868ec8a

• Graph and module nesting - operation mode injected, implemented functionality with unit/integration tests

  Show description for 51e852c
  tkornuta-nvidia

  committed
  51e852c

• formatting fix

  Show description for e2ed33a
  tkornuta-nvidia

  committed
  e2ed33a

• merged with master

  Show description for 069dd10
  tkornuta-nvidia

  committed
  069dd10

• cleanup of output port logic in __call__, other cleanups, LGTM fixes

  Show description for a054311
  tkornuta-nvidia

  committed
  a054311

• Further cleanup of neural_modules.py

  Show description for c0e5f0b
  tkornuta-nvidia

  committed
  c0e5f0b

• LGTM cleanups

  Show description for 98cfe43
  tkornuta-nvidia

  committed
  98cfe43

• style fix:]

  Show description for d109b5c
  tkornuta-nvidia

  committed
  d109b5c

• micro cleanup

  Show description for 6487a65
  tkornuta-nvidia

  committed
  6487a65

• micro cleanup2

  Show description for 6c16c6e
  tkornuta-nvidia

  committed
  6c16c6e

• punctuation module name fix

  Show description for b7d3f1c
  tkornuta-nvidia

  committed
  b7d3f1c

Commits on Apr 10, 2020

• Working on NmTensor extensions

  Show description for 5548495
  tkornuta-nvidia

  committed
  5548495

• style fix

  Show description for c835279
  tkornuta-nvidia

  committed
  c835279

• Cleaned up the call output tensor logic in neural module and graph classes

  Show description for 70320fe
  tkornuta-nvidia

  committed
  70320fe

• NmTensor test cleanup

  Show description for c9b2585
  tkornuta-nvidia

  committed
  c9b2585

• style fix

  Show description for adeeccc
  tkornuta-nvidia

  committed
  adeeccc

• LGTM cleanups

  Show description for 127307b
  tkornuta-nvidia

  committed
  127307b

• style fixes

  Show description for 7b52fbe
  tkornuta-nvidia

  committed
  7b52fbe

• BoundOutputs class and unit tests

  Show description for 81b87ea
  tkornuta-nvidia

  committed
  81b87ea

• style fixes

  Show description for fbfc87e
  tkornuta-nvidia

  committed
  fbfc87e

• manual output port binding operational

  Show description for 41ee935
  tkornuta-nvidia

  committed
  41ee935

• manual output port binding operational

  Show description for bce7e90
  tkornuta-nvidia

  committed
  bce7e90

Commits on Apr 14, 2020

• Recording and updating all modules during connecting to a graph

  Show description for 752b810
  tkornuta-nvidia

  committed
  752b810

Commits on Apr 15, 2020

• work in progress on output port binding, not operations

  Show description for f68c883
  tkornuta-nvidia

  committed
  f68c883

• bound output test fix

  Show description for 9c3f78b
  tkornuta-nvidia

  committed
  9c3f78b

• preparing ground for tensor copy

  Show description for b8bf040
  tkornuta-nvidia

  committed
  b8bf040

Commits on Apr 18, 2020

• Rewritten graph nesting - works by executing inner graph modules' call() - operational, all examples working

  Show description for 691e90b
  tkornuta-nvidia

  committed
  691e90b

• fixed tests, formatted the code

  Show description for ec2bfe6
  tkornuta-nvidia

  committed
  ec2bfe6

Commits on Apr 21, 2020

• refactoring and cleanup of neural graphs

  Show description for cb250da
  tkornuta-nvidia

  committed
  cb250da

• Refactoring, cleanups of NeuralGraphs nesting/binding

  Show description for 6907cd7
  tkornuta-nvidia

  committed
  6907cd7

• reformating fix

  Show description for cb69367
  tkornuta-nvidia

  committed
  cb69367

Commits on Apr 22, 2020

• Fixes, unit tests for binding of nested graphs, automatic and manual, inputs and outputs: passing

  Show description for 8389f21
  tkornuta-nvidia

  committed
  8389f21

• Added several tests for graph nesting, covered (and fixed) case of passing names from inner to outer graph in manual output port binding

  Show description for 9235ca8
  tkornuta-nvidia

  committed
  9235ca8

• final tests for graph nesting

  Show description for 59b1d75
  tkornuta-nvidia

  committed
  59b1d75

• style fix

  Show description for fc9d995
  tkornuta-nvidia

  committed
  fc9d995

Commits on Apr 23, 2020

• refactored the neural module serialization, made it more modular, so can use its pieces in graph serialization

  Show description for ece11c3
  tkornuta-nvidia

  committed
  ece11c3

• style fix

  Show description for cd703de
  tkornuta-nvidia

  committed
  cd703de

• graph serialization 80%

  Show description for 465979d
  tkornuta-nvidia

  committed
  465979d

• graph serialization operational

  Show description for ba46466
  tkornuta-nvidia

  committed
  ba46466

Commits on Apr 24, 2020

• work on deserialization, working up to the execution of graph

  Show description for fa1e4b3
  tkornuta-nvidia

  committed
  fa1e4b3

• format fix

  Show description for b810243
  tkornuta-nvidia

  committed
  b810243

Commits on Apr 27, 2020

• serialization and deserialization of JASPER (processor, encoder and decoder) working

  Show description for 9f46e20
  tkornuta-nvidia

  committed
  9f46e20

• Merge remote-tracking branch 'origin/master' into merge

  tkornuta-nvidia

  committed
  77ad78d

• merged with master and reformatted

  Show description for 7b5b9d4
  tkornuta-nvidia

  committed
  7b5b9d4

Commits on Apr 28, 2020

• Updated EN and ZH:] version of documentation for configuration/custom configuration

  Show description for 26a7621
  tkornuta-nvidia

  committed
  26a7621

• Unification of singleton meta class

  Show description for 314cf10
  tkornuta-nvidia

  committed
  314cf10

• Added to the train() function signatures

  Show description for 7f0ee86
  tkornuta-nvidia

  committed
  7f0ee86

• formatting fix

  Show description for 4076808
  tkornuta-nvidia

  committed
  4076808

• LGTM fixes

  Show description for 41bb68f
  tkornuta-nvidia

  committed
  41bb68f

• line numbers

  Show description for cb56b35
  tkornuta-nvidia

  committed
  cb56b35

• Tweak of deserialize - moved name and overwrite_params

  Show description for 5ff3896
  tkornuta-nvidia

  committed
  5ff3896

• style fix

  Show description for c955a7a
  tkornuta-nvidia

  committed
  c955a7a

• Commeting the condition for both None: eval() seems to be calling :]

  Show description for 3b47bd9
  tkornuta-nvidia

  committed
  3b47bd9

• LGTM fix

  Show description for fd88c70
  tkornuta-nvidia

  committed
  fd88c70

• method comment

  Show description for 98b03cf
  tkornuta-nvidia

  committed
  98b03cf

• reorganization of directories in unit/core/utils

  Show description for 18077fc
  tkornuta-nvidia

  committed
  18077fc

• Fix of NM init_params collection, made it much more robust and faster, fixes of the ObjectRegistry summary, first tests of graph serialization/deserialization

  Show description for a7a04e3
  tkornuta-nvidia

  committed
  a7a04e3

• Renamed NG integration tests

  Show description for a932c8a
  tkornuta-nvidia

  committed
  a932c8a

• formatting

  Show description for 7c57cdf
  tkornuta-nvidia

  committed
  7c57cdf

• additional tests

  Show description for 6d785f1
  tkornuta-nvidia

  committed
  6d785f1

• style fix

  Show description for 5633963
  tkornuta-nvidia

  committed
  5633963

• A simple test for graph config import and export

  Show description for 8f6ddc5
  tkornuta-nvidia

  committed
  8f6ddc5

Commits on Apr 29, 2020

• add a nmtensor registry

  Show description for 0498558
  blisc

  committed
  0498558

• import/export/serialization/deserialization tests cnt, minor fixes here and there

  Show description for 1977db0
  tkornuta-nvidia

  committed
  1977db0

• minor cleanup, unit test: a simple graph with a loop (not passing)

  Show description for bd6c12e
  tkornuta-nvidia

  committed
  bd6c12e

• style fix

  Show description for 7463dd8
  tkornuta-nvidia

  committed
  7463dd8

• Refactored the whole solution, switching from module_name:port_name to step_number:module_name:port_name (or in case of tensors: step_number:port_name). In short: enabled neural graphs to handle lo…

  Show description for 17e4dd9
  tkornuta-nvidia

  committed
  17e4dd9

• format fix

  Show description for 7b94c57
  tkornuta-nvidia

  committed
  7b94c57

• Added neural type export to config file for both graph bound input and output ports, Polishes, cleanups, unit tests working

  Show description for e5917fe
  tkornuta-nvidia

  committed
  e5917fe

• jasper polished

  Show description for 35b31c9
  tkornuta-nvidia

  committed
  35b31c9

• Merge remote-tracking branch 'nvidia/fix-sign' into U_callbacks_2

  Show description for c5811c1
  blisc

  committed
  c5811c1

Commits on Apr 30, 2020

• first working example

  Show description for 948f847
  blisc

  committed
  948f847

• fix style

  Show description for a98c190
  blisc

  committed
  a98c190

• add 'loss' to state

  Show description for ad5ba14
  blisc

  committed
  ad5ba14

Commits on May 1, 2020

• PR polish, added type hints to all classes, added graph summary

  Show description for 5375055
  tkornuta-nvidia

  committed
  5375055

• removed 'name' in for in actions.py

  Show description for 9f6ee98
  tkornuta-nvidia

  committed
  9f6ee98

• NG-related integration tests

  Show description for 45dacd3
  tkornuta-nvidia

  committed
  45dacd3

• LGTM fix

  Show description for 356e0c2
  tkornuta-nvidia

  committed
  356e0c2

• bind description updated

  Show description for cd1e23e
  tkornuta-nvidia

  committed
  cd1e23e

• removed app_state from jasper

  Show description for 37ba923
  tkornuta-nvidia

  committed
  37ba923

• graph input_ports and output_ports are now immutable, added some unit tests that check that, minor cleanups

  Show description for e28979e
  tkornuta-nvidia

  committed
  e28979e

Commits on May 2, 2020

• removed a line - formatting fix :]

  Show description for 693b744
  tkornuta-nvidia

  committed
  693b744

• name fix in test

  Show description for 413c0fa
  tkornuta-nvidia

  committed
  413c0fa

• Minor touches here and there

  Show description for ccc1b21
  tkornuta-nvidia

  committed
  ccc1b21

• Unique names generates from names of classes

  Show description for a191dbe
  tkornuta-nvidia

  committed
  a191dbe

Commits on May 4, 2020

• moved graph managed to utils, removed it from init

  Show description for 68bd7e2
  tkornuta-nvidia

  committed
  68bd7e2

• Moved neural_graph_manager to utils that enable to remove it (along with ObjectRegistry) from __init__ files

  Show description for bc216db
  tkornuta-nvidia

  committed
  bc216db

• removed graph examples

  Show description for c54156c
  tkornuta-nvidia

  committed
  c54156c

• Updated docstring in GraphInputs

  Show description for cf72cf8
  tkornuta-nvidia

  committed
  cf72cf8

• Moved all NeuralGraph helper classes to nemo.utils.neural_graph. AppState remained in the nemo.utils

  Show description for 327cc6d
  tkornuta-nvidia

  committed
  327cc6d

Commits on May 5, 2020

• inference -> evaluation, as requested

  Show description for 831d269
  tkornuta-nvidia

  committed
  831d269

• fix

  Show description for d2615e1
  tkornuta-nvidia

  committed
  d2615e1

• changelog updated

  Show description for da91ec0
  tkornuta-nvidia

  committed
  da91ec0

Commits on May 6, 2020

• merge with fix sign

  Show description for 579be8e
  blisc

  committed
  579be8e

• merge with master

  Show description for cffee88
  blisc

  committed
  cffee88