Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback PR Rev 2 #597

Closed
wants to merge 113 commits into from
Closed

Callback PR Rev 2 #597

wants to merge 113 commits into from

Conversation

blisc
Copy link
Collaborator

@blisc blisc commented Apr 29, 2020 •
edited
Loading

Rebased on top of Neural Graph PR

Tasks:

  • Create a NmTensor Registry
  • Add tensor.register inside of Neural Module calls NmTensor.init()
  • Allow users to rename their tensors
  • Creating state during steps
    • Resetting state after each step
    • Pass state to callbacks
    • Allow users to access tensors from state
  • Map state["loss"] to final_loss
  • Allow users to compute value of uncomputed tensors
  • Refactor SimpleLossLogger
  • Create function decorators

tkornuta-nvidia and others added 30 commits March 24, 2020 13:39
@tkornuta-nvidia
Manual rebase of dev-module-composition on top of current master
de587bd 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Adding neural graph examples
15b3b11 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
formatting fixes
2756a66 
Signed-off-by: Tomasz Kornuta <[email protected]>
@blisc
new proposal
5bad9c9 
Signed-off-by: Jason <[email protected]>
@tkornuta-nvidia
Merge branch 'master' of github.com:NVIDIA/NeMo into fix-sign
e26a906
@tkornuta-nvidia
Merge branch 'fix-sign' of github.com:NVIDIA/NeMo into fix-sign
85bb729
@tkornuta-nvidia
format fix of Jason's example
0576ce7 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Added modules recording, with retrieval of module name
3f1ac01 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
keyerror comment
a57b34d 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Introduced name property of modules
fc3deac 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
implemented NameRegistry basic functionality, test5 working, unit tes…
5221fef 
…ts failing

Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
example 5 working, ObjectRegistry finished, app_state moved to utils
dd9af75 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
test app_state fixed
ab35621 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
TokenClassification self.name fix
bbd3589 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
ObjectRegistry tests
56efff5 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
cleanup of neural graphs class, NG manager inheriting from ObjectRegi…
c838f13 
…stry, starting to work on graph unit tests

Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
fixes to graph and manager, NeMo tests passing (locally)
1153001 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
code formatting
9df6568 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
turning examples into unit/integration tests, small fixes here and th…
868ec8a 
…ere, work in progress

Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Graph and module nesting - operation mode injected, implemented funct…
51e852c 
…ionality with unit/integration tests

Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
formatting fix
e2ed33a 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
merged with master
069dd10 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
cleanup of output port logic in __call__, other cleanups, LGTM fixes
a054311 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Further cleanup of neural_modules.py
c0e5f0b 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
LGTM cleanups
98cfe43 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
style fix:]
d109b5c 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
micro cleanup
6487a65 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
micro cleanup2
6c16c6e 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
punctuation module name fix
b7d3f1c 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Working on NmTensor extensions
5548495 
Signed-off-by: Tomasz Kornuta <[email protected]>
@okuchaiev okuchaiev self-assigned this May 1, 2020
@okuchaiev okuchaiev self-requested a review May 1, 2020 05:22
tkornuta-nvidia and others added 15 commits May 1, 2020 16:30
@tkornuta-nvidia
graph input_ports and output_ports are now immutable, added some unit…
e28979e 
… tests that check that, minor cleanups

Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
removed a line - formatting fix :]
693b744 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
name fix in test
413c0fa 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Minor touches here and there
ccc1b21 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Unique names generates from names of classes
a191dbe 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
moved graph managed to utils, removed it from init
68bd7e2 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Moved neural_graph_manager to utils that enable to remove it (along w…
bc216db 
…ith ObjectRegistry) from __init__ files

Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
removed graph examples
c54156c 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Updated docstring in GraphInputs
cf72cf8 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
Moved all NeuralGraph helper classes to nemo.utils.neural_graph. AppS…
327cc6d 
…tate remained in the nemo.utils

Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
inference -> evaluation, as requested
831d269 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
fix
d2615e1 
Signed-off-by: Tomasz Kornuta <[email protected]>
@tkornuta-nvidia
changelog updated
da91ec0 
Signed-off-by: Tomasz Kornuta <[email protected]>
@blisc
merge with fix sign
579be8e 
Signed-off-by: Jason <[email protected]>
@blisc
merge with master
cffee88 
Signed-off-by: Jason <[email protected]>
@blisc blisc changed the base branch from fix-sign to master May 6, 2020 20:48
@blisc blisc mentioned this pull request May 6, 2020
Merged
17 tasks
@blisc blisc closed this May 6, 2020
@lgtm-com
Copy link

lgtm-com bot commented May 6, 2020

This pull request introduces 8 alerts and fixes 1 when merging cffee88 into da91ec0 - view on LGTM.com

new alerts:

  • 5 for Unused local variable
  • 3 for Unused import

fixed alerts:

  • 1 for Signature mismatch in overriding method

@lgtm-com
Copy link

lgtm-com bot commented May 6, 2020

This pull request introduces 8 alerts when merging cffee88 into d219483 - view on LGTM.com

new alerts:

  • 5 for Unused local variable
  • 3 for Unused import

@blisc blisc deleted the U_callbacks_2 branch May 28, 2020 22:05
dcurran90 pushed a commit to dcurran90/NeMo that referenced this pull request Oct 15, 2024
@nerdalert
MD lint the /docs/* dir (NVIDIA#597)
3652034 
MD lint the /docs dir

Signed-off-by: Brent Salisbury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okuchaiev okuchaiev Awaiting requested review from okuchaiev

Assignees

@okuchaiev okuchaiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blisc @okuchaiev @tkornuta-nvidia