Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-dataset #538

Merged
merged 8 commits into from
Apr 10, 2020
Merged

multi-dataset #538

merged 8 commits into from
Apr 10, 2020

Conversation

yzhang123
Copy link
Contributor

Signed-off-by: Yang Zhang [email protected]

@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2020

This pull request introduces 1 alert when merging 30d9497 into 9b23de2 - view on LGTM.com

new alerts:

  • 1 for Asserting a tuple

@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2020

This pull request introduces 1 alert when merging e90da39 into 9b23de2 - view on LGTM.com

new alerts:

  • 1 for Asserting a tuple

@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2020

This pull request introduces 1 alert when merging efb4b32 into e723539 - view on LGTM.com

new alerts:

  • 1 for Asserting a tuple

@yzhang123 yzhang123 requested a review from okuchaiev April 1, 2020 21:46
@yzhang123 yzhang123 changed the title added pytest for multi-dataset multi-dataset Apr 1, 2020
@yzhang123 yzhang123 requested a review from blisc April 2, 2020 00:06
Copy link
Member

@okuchaiev okuchaiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments

nemo/backends/pytorch/tutorials/toys.py Show resolved Hide resolved
nemo/backends/pytorch/common/multi_data.py Show resolved Hide resolved
@yzhang123 yzhang123 requested a review from okuchaiev April 7, 2020 01:32
okuchaiev
okuchaiev previously approved these changes Apr 7, 2020
@blisc
Copy link
Collaborator

blisc commented Apr 7, 2020

Add a changelog message, and please un-draft your PR is it is ready

@yzhang123 yzhang123 requested review from redoctopus and removed request for blisc April 9, 2020 23:03
@yzhang123 yzhang123 marked this pull request as ready for review April 9, 2020 23:04
@yzhang123 yzhang123 merged commit cbf16b6 into master Apr 10, 2020
@ekmb ekmb deleted the multidataset branch July 17, 2020 17:47
dcurran90 pushed a commit to dcurran90/NeMo that referenced this pull request Oct 15, 2024
* docs: update workflow

Signed-off-by: Kai Xu <[email protected]>

* docs: update rendered workflow

Signed-off-by: Kai Xu <[email protected]>

---------

Signed-off-by: Kai Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants