Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes to SentencePiece for T5 #3515

Merged
merged 5 commits into from
Jan 28, 2022
Merged

More fixes to SentencePiece for T5 #3515

merged 5 commits into from
Jan 28, 2022

Conversation

MaximumEntropy
Copy link
Contributor

No description provided.

Signed-off-by: MaximumEntropy <[email protected]>
@MaximumEntropy MaximumEntropy changed the title More fixes to spm for T5 More fixes to SentencePiece for T5 Jan 26, 2022
ericharper
ericharper previously approved these changes Jan 26, 2022
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Signed-off-by: MaximumEntropy <[email protected]>
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ericharper ericharper merged commit 33290ac into main Jan 28, 2022
@ericharper ericharper deleted the t5_spm_fix branch January 28, 2022 19:48
nithinraok pushed a commit that referenced this pull request Feb 2, 2022
* More fixes to spm for T5

Signed-off-by: MaximumEntropy <[email protected]>

* Style fixes

Signed-off-by: MaximumEntropy <[email protected]>
fayejf pushed a commit that referenced this pull request Mar 2, 2022
* More fixes to spm for T5

Signed-off-by: MaximumEntropy <[email protected]>

* Style fixes

Signed-off-by: MaximumEntropy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants