Skip to content

Commit

Permalink
Style fixes
Browse files Browse the repository at this point in the history
Signed-off-by: MaximumEntropy <[email protected]>
  • Loading branch information
MaximumEntropy committed Jan 26, 2022
1 parent f6a8ea0 commit 3b28c8d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,9 @@ def unk_id(self):
@property
def additional_special_tokens_ids(self):
"""Returns a list of the additional special tokens (excluding bos, eos, pad, unk). Used to return sentinel tokens for e.g. T5."""
special_tokens = set([self.bos_token, self.eos_token, self.pad_token, self.mask_token, self.cls_token, self.sep_token])
special_tokens = set(
[self.bos_token, self.eos_token, self.pad_token, self.mask_token, self.cls_token, self.sep_token]
)
return [v for k, v in self.special_token_to_id.items() if k not in special_tokens]

@property
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,11 @@ def _add_special_tokens_to_tokenizer(self):
self.tokenizer.add_special_tokens({'eos_token': '</s>'})

# Special check to see if <extra_id_{}> is already present in the tokenizer. If it is, only modify the additional_special_tokens function.
for i in range (self.num_sentinel_tokens):
for i in range(self.num_sentinel_tokens):
if f'▁<extra_id_{i}>' in self.tokenizer.vocab:
self.tokenizer.special_token_to_id[f'<extra_id_{i}>'] = self.tokenizer.text_to_ids(f'<extra_id_{i}>')[0]
self.tokenizer.special_token_to_id[f'<extra_id_{i}>'] = self.tokenizer.text_to_ids(
f'<extra_id_{i}>'
)[0]
else:
self.tokenizer.add_special_tokens([f'<extra_id_{i}>'])

Expand Down
3 changes: 2 additions & 1 deletion nemo/collections/nlp/modules/common/lm_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,10 @@ def get_lm_model(
)

if nemo_file is not None:
from nemo.collections.nlp.models.language_modeling.megatron_bert_model import MegatronBertModel
import torch

from nemo.collections.nlp.models.language_modeling.megatron_bert_model import MegatronBertModel

class Identity(torch.nn.Module):
def __init__(self):
super(Identity, self).__init__()
Expand Down

0 comments on commit 3b28c8d

Please sign in to comment.