Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf recipes and Mcore DistOpt params #10883
perf recipes and Mcore DistOpt params #10883
Changes from all commits
0175f4c
9df8e0d
dd40e45
f71a880
e51c427
0f38ee9
565ddb0
3a26f96
37a6e78
6ccff07
9aaa80b
5c55c4e
7e38d57
9cb9b65
241c3d5
76d2ea0
df831f4
5c5634c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be a bit afraid that this will blow up the number of recipes that we show in the CLI. Since we allow the user to call the recipe with arguments, what about adding a new arg to the pretrain recipes that will dictate if we use the performance one or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree @marcromeyn . But, should we do this as a follow-up PR as this would involve performance recipes for all models (I assume) and the interface for perf recipe/perf mode would also change. Reviewing would be difficult/erroneous?
Also, cc: @erhoo82 @JimmyZhang12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcromeyn We need this performance recipe for every key model training because the baseline recipe is missing many performance features and it is hard to communicate with users without having a recipe that has all the important perf features. There is a high risk that a user can miss out many of them without asking us for the actual CLI command line every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericharper As we discussed, the baseline recipe is for debugging and we need a performance recipe for all model training.
BTW, are we supposed to have different recipes for different sequence lengths?
Also, one question on the global batch size here.
#10905
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sequence lengths have their own recipe, for example: https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/recipes/llama3_70b_64k.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericharper
Yes, I see that it uses different a CP size for the target seqlen. So, I think it is only TP and CP mapping that needs to be changed. Do we need a full recipe only for this change? Also, I think the global batch size there seems to be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided previously to include the full recipe for this but we could revisit it. If there's a bug please send a fix.
@malay-nagda we can merge this as is, but please send a follow up PR with @marcromeyn 's suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created another draft PR with @marcromeyn's suggestion- #10926
waiting for this PR to be merged so that I can update #10926