Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance mode #10926

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Performance mode #10926

merged 9 commits into from
Oct 21, 2024

Conversation

malay-nagda
Copy link
Collaborator

@malay-nagda malay-nagda commented Oct 17, 2024

What does this PR do ?

Add performance optimizations as a param

Collection: [llm]

Changelog

if performance_mode:
    recipe = pretrain_performance_optimizations(recipe)

Usage

from nemo.collections.llm.recipes.llama3_8b import pretrain_recipe

recipe = pretrain_recipe(dir='a/b/c', performance_mode=True)

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@@ -155,6 +156,7 @@ def pretrain_recipe(
name (str): Name of the pre-training run.
num_nodes (int): Number of compute nodes to use.
num_gpus_per_node (int): Number of GPUs per node.
performance_mode (bool): If true, enables optimizations for maximum performance.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcromeyn does this look good to you? Context- your comment here- #10883 (comment)

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
malay-nagda and others added 4 commits October 19, 2024 00:30
@malay-nagda malay-nagda marked this pull request as ready for review October 18, 2024 19:30
@pablo-garay pablo-garay merged commit c7a539a into NVIDIA:main Oct 21, 2024
169 of 171 checks passed
artbataev pushed a commit to artbataev/NeMo that referenced this pull request Oct 22, 2024
* llama3 performance mode

Signed-off-by: Malay Nagda <[email protected]>

* llama3 performance mode tests

Signed-off-by: Malay Nagda <[email protected]>

* mixtral performance mode

Signed-off-by: Malay Nagda <[email protected]>

* remove unused

Signed-off-by: Malay Nagda <[email protected]>

* nemotron perf mode

Signed-off-by: Malay Nagda <[email protected]>

* 405b, 174b perf mode

Signed-off-by: Malay Nagda <[email protected]>

* perf mode comment

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
akoumpa pushed a commit that referenced this pull request Oct 24, 2024
* llama3 performance mode

Signed-off-by: Malay Nagda <[email protected]>

* llama3 performance mode tests

Signed-off-by: Malay Nagda <[email protected]>

* mixtral performance mode

Signed-off-by: Malay Nagda <[email protected]>

* remove unused

Signed-off-by: Malay Nagda <[email protected]>

* nemotron perf mode

Signed-off-by: Malay Nagda <[email protected]>

* 405b, 174b perf mode

Signed-off-by: Malay Nagda <[email protected]>

* perf mode comment

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
malay-nagda added a commit to malay-nagda/NeMo that referenced this pull request Oct 24, 2024
* llama3 performance mode

Signed-off-by: Malay Nagda <[email protected]>

* llama3 performance mode tests

Signed-off-by: Malay Nagda <[email protected]>

* mixtral performance mode

Signed-off-by: Malay Nagda <[email protected]>

* remove unused

Signed-off-by: Malay Nagda <[email protected]>

* nemotron perf mode

Signed-off-by: Malay Nagda <[email protected]>

* 405b, 174b perf mode

Signed-off-by: Malay Nagda <[email protected]>

* perf mode comment

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
erhoo82 pushed a commit that referenced this pull request Oct 24, 2024
* Performance mode (#10926)

* llama3 performance mode

Signed-off-by: Malay Nagda <[email protected]>

* llama3 performance mode tests

Signed-off-by: Malay Nagda <[email protected]>

* mixtral performance mode

Signed-off-by: Malay Nagda <[email protected]>

* remove unused

Signed-off-by: Malay Nagda <[email protected]>

* nemotron perf mode

Signed-off-by: Malay Nagda <[email protected]>

* 405b, 174b perf mode

Signed-off-by: Malay Nagda <[email protected]>

* perf mode comment

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>

* gpt3 175b cli (#10985)

* gpt3 175b cli

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
yashaswikarnati pushed a commit that referenced this pull request Oct 24, 2024
* llama3 performance mode

Signed-off-by: Malay Nagda <[email protected]>

* llama3 performance mode tests

Signed-off-by: Malay Nagda <[email protected]>

* mixtral performance mode

Signed-off-by: Malay Nagda <[email protected]>

* remove unused

Signed-off-by: Malay Nagda <[email protected]>

* nemotron perf mode

Signed-off-by: Malay Nagda <[email protected]>

* 405b, 174b perf mode

Signed-off-by: Malay Nagda <[email protected]>

* perf mode comment

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
titu1994 pushed a commit that referenced this pull request Oct 28, 2024
* llama3 performance mode

Signed-off-by: Malay Nagda <[email protected]>

* llama3 performance mode tests

Signed-off-by: Malay Nagda <[email protected]>

* mixtral performance mode

Signed-off-by: Malay Nagda <[email protected]>

* remove unused

Signed-off-by: Malay Nagda <[email protected]>

* nemotron perf mode

Signed-off-by: Malay Nagda <[email protected]>

* 405b, 174b perf mode

Signed-off-by: Malay Nagda <[email protected]>

* perf mode comment

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* llama3 performance mode

Signed-off-by: Malay Nagda <[email protected]>

* llama3 performance mode tests

Signed-off-by: Malay Nagda <[email protected]>

* mixtral performance mode

Signed-off-by: Malay Nagda <[email protected]>

* remove unused

Signed-off-by: Malay Nagda <[email protected]>

* nemotron perf mode

Signed-off-by: Malay Nagda <[email protected]>

* 405b, 174b perf mode

Signed-off-by: Malay Nagda <[email protected]>

* perf mode comment

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* llama3 performance mode

Signed-off-by: Malay Nagda <[email protected]>

* llama3 performance mode tests

Signed-off-by: Malay Nagda <[email protected]>

* mixtral performance mode

Signed-off-by: Malay Nagda <[email protected]>

* remove unused

Signed-off-by: Malay Nagda <[email protected]>

* nemotron perf mode

Signed-off-by: Malay Nagda <[email protected]>

* 405b, 174b perf mode

Signed-off-by: Malay Nagda <[email protected]>

* perf mode comment

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants