Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors found when using cudf 0.17:
KeyError: None
intests/unit/test_dask_nvt.py::test_dask_workflow_api_dlrm
index=False
in NVTabularAssertionError: DataFrame.index
are different intests/unit/test_io.py::test_dask_dataset
check_index=False
since we don't care about matching indices in NVTabular. That solved the Parquet error, but creates errors for csv. @rjzamora does not get the csv errors and it works for him.assert <NA> is None
intest_ops.py::test_difference_lag
dtype: bool
, we were doing the following operationmask[mask == False] = None
. The resulting dataframe contains<NA>
values instead ofNone
. This is expected, cudf has stopped using None and instead is using<NA>
to be coherent with pandas (cudf.NA
).ValueError: Length mismatch: Expected axis has
in test_workflow.py, test_torch_dataloader.py, test_ops.py, and test_io.pyValueError: Length mismatch: Expected axis has 10 elements, new values have 2 elements
. @rjzamora was guessing to be a cudf bug for reading BytesIO Objects, he has raisen an issue in cudf. Keith Kraus guess that it may be related to the boolean masking change if "doing something like gdf[gdf['col'] == x] where any value of gdf['col'] which is will return False for the purpose of boolean masking".TODO: Fix errors:
KeyError: None
AssertionError: DataFrame.index
assert <NA> is None
ValueError: Length mismatch: Expected axis has