Add Bibtex referencing #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable to the page in React Co-Authored-By: Moosa Hassan <[email protected]>
Co-Authored-By: Moosa Hassan <[email protected]> Co-Authored-By: SinisterSamtaro94 <[email protected]>
Co-Authored-By: Moosa Hassan <[email protected]> Co-Authored-By: SinisterSamtaro94 <[email protected]>
Co-Authored-By: Moosa Hassan <[email protected]> Co-Authored-By: SinisterSamtaro94 <[email protected]>
Co-Authored-By: Moosa Hassan <[email protected]> Co-Authored-By: SinisterSamtaro94 <[email protected]>
Co-Authored-By: Moosa Hassan <[email protected]> Co-Authored-By: SinisterSamtaro94 <[email protected]>
Co-Authored-By: Moosa Hassan <[email protected]> Co-Authored-By: SinisterSamtaro94 <[email protected]>
<references/> tag reads .bib
JosephusPaye
commented
Dec 3, 2020
…. Extensions has not been done.
…Ubots/NUbook into paye-hassan-dearie/referencing
|
This should be ready to review and merge now. |
ysims
reviewed
Feb 2, 2022
There was a problem hiding this comment.
Some comments on the styling, but these are just opinions.
- From a user point of view, I'm not keen on actually having unknown references shown on the page. Is it possible to just throw an error? I don't see any benefit to showing it, and I was confused for a couple of seconds when I saw the first reference because I initially interpretted it as 'the first reference in the list is an unknown reference' before realising it was two separate references next to each other.
- I don't know if I really like the way the inline citations look. After looking at it in dark mode, I think it's just that the darkness of the background in light mode feels a bit too noticable. Maybe it'd be better to have a light background with dark text like the references list at the bottom?
ysims
reviewed
Feb 4, 2022
There was a problem hiding this comment.
Styling looks good. Looked through some of the code and didn't see anything concerning but I can't say I know js well enough to comment.
@lach-j can you check out the js? If that's good and no one has any other issues then I think it can be approved.
|
@JosephusPaye probs also make an issue for those extensions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By @moosahassanx, @samtarino94, and myself.
This PR adds a Bibtex referencing system to NUbook, much like the one in Overleaf.
Tasks
<cite>element to show inline citations, with an error when a citation used is not found in the bib file<References>elementExtensions (for future PRs)
Preview
https://deploy-preview-69--nubook.netlify.app/kitchen-sink/referencing
Docs
https://deploy-preview-69--nubook.netlify.app/system/tools/nubook#bibtex-referencing