Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unvented crawlspace upgrade #870

Merged
merged 20 commits into from
Apr 11, 2022
Merged

Unvented crawlspace upgrade #870

merged 20 commits into from
Apr 11, 2022

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Mar 30, 2022 •
edited
Loading

Pull Request Description

Closes #869.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected integration/regression test changes

@joseph-robertson joseph-robertson added this to the ResStock v2.6.0 Beta milestone Mar 30, 2022
@joseph-robertson joseph-robertson self-assigned this Mar 30, 2022
@shorowit
Copy link
Contributor

@ejhw Note the definition used by OS-HPXML is that a conditioned crawlspace is actively maintained at setpoint. If all you are evaluating is sealing/insulating the crawlspace, but not actively providing conditioned air to it, then you should probably use the unvented crawlspace foundation type.

@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented Mar 31, 2022 •
edited
Loading

Decision to change conditioned to unvented.

Leave any floor insulation, and add R-10 foundation wall insulation. (Adding R-10 foundation wall insulation when there is floor insulation might be pretty cost ineffective.)

Add "Floor Area, Below-Grade (ft^2)", and then use this cost multiplier in the *_upgrades.yml files (value at 0.84).

joseph-robertson and others added 6 commits April 4, 2022 09:00
@joseph-robertson
Merge branch 'develop' into conditioned-crawl-upgrade
c2fec90
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from b3afe1c1fe08..9be6b…
ed2cd34 
…48fb6c9

9be6b48fb6c9 Merge pull request #1027 from NREL/foundation-floor-area
fcb76b8aa1f0 Use new method throughout test.
89ecff3bb5e3 Add test for various foundations.
689cf5ff2086 Exclude garages from foundation floors.
62bf4d1d56ef Foundation slab could be at grade.
d85026c649a1 Update the changelog.
d7494630ba16 Update docs.
c94657aa98f8 Update tests.
cc7aa49ba455 Add new multiplier to measure and constants.
5c0bd9b56438 Merge pull request #1012 from NREL/additional-properties-updates
8fa43c9bb448 Update Changelog.md
2569aeb17804 Minor cleanup. Reverts EPvalidator.xml and docs changes.
39032492560d Latest results.
5717b02e84a1 Merge branch 'master' into additional-properties-updates
eab2693294df Update description and docs.
a0176f01e5cb Merge pull request #1010 from NREL/fix_timeseries_emissions
15dc8bc1f0b0 Latest results.
3961f4dfd771 Update Changelog.md [ci skip]
6e981e11bc0a Latest results.
c8ea2273a98e Test more characters.
dea7fa60c414 Latest results.
ddc83ef99c93 Merge branch 'master' into additional-properties-updates
b5d2f37c644f Fixes and updates to tear down method.
63df131dbb14 Add convenience method for retrieving additional properties.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 9be6b48fb6c978358cc8e942001ac2b2a9586eae
@joseph-robertson
Merge commit 'ed2cd344af1df7c584a10b1ee61d6a2ca2e5434b' into conditio…
613d0e8 
…ned-crawl-upgrade
@joseph-robertson
Add new cost multiplier.
1cf955e
@joseph-robertson
Update example ymls.
4af06ff
Latest results.
4674a9a
@joseph-robertson joseph-robertson marked this pull request as ready for review April 4, 2022 19:40
@joseph-robertson joseph-robertson requested a review from ejhw April 5, 2022 16:22
ejhw
ejhw approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@ejhw ejhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @ekpresent @afontani

@shorowit
Copy link
Contributor

shorowit commented Apr 5, 2022

@joseph-robertson Can you attach before/after HPXMLs for one of the test homes?

shorowit
shorowit reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the documentation needs to be updated. Review the PR checklist?

@joseph-robertson
Copy link
Contributor Author

@joseph-robertson Can you attach before/after HPXMLs for one of the test homes?

before.xml.txt
after.xml.txt

@joseph-robertson joseph-robertson changed the title Conditioned crawlspace upgrade Unvented crawlspace upgrade Apr 5, 2022
@shorowit
Copy link
Contributor

shorowit commented Apr 5, 2022

@joseph-robertson Can you attach before/after HPXMLs for one of the test homes?

before.xml.txt after.xml.txt

Thanks. That does look good. Did you intentionally decide not to include foundation wall insulation (see here) in the upgrade?

@joseph-robertson
Copy link
Contributor Author

@joseph-robertson Can you attach before/after HPXMLs for one of the test homes?

before.xml.txt after.xml.txt

Thanks. That does look good. Did you intentionally decide not to include foundation wall insulation (see here) in the upgrade?

In the example ymls? I did not.

@joseph-robertson
Copy link
Contributor Author

With R-10 foundation wall insulation:
before.xml.txt
after.xml.txt

@joseph-robertson joseph-robertson merged commit e0050be into develop Apr 11, 2022
@joseph-robertson joseph-robertson deleted the conditioned-crawl-upgrade branch April 11, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhw ejhw ejhw approved these changes

@shorowit shorowit shorowit approved these changes

Assignees

@joseph-robertson joseph-robertson

Labels
None yet
Projects
None yet
Milestone
ResStock v3.0.0
Development

Successfully merging this pull request may close these issues.

Create/test option for upgrading vented crawlspace to unvented crawlspace
3 participants
@joseph-robertson @shorowit @ejhw