rogue FIXMEs in 'Water Heater Efficiency' options?
#1010
Comments
|
The "FIXME" string is intentionally inserted into the "Oil Indirect" Water Heater Efficiency option. It is used to denote that we currently model a "storage water heater" instead of a "space-heating boiler with storage tank" (i.e., combi boiler/tank system). |
joseph-robertson
pushed a commit
that referenced
this issue
Feb 3, 2023
f492e9f0c4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os340 a0176f01e5 Merge pull request #1010 from NREL/fix_timeseries_emissions 15dc8bc1f0 Latest results. 3961f4dfd7 Update Changelog.md [ci skip] b3afe1c1fe Fix net energy calculation from merge. 3009106693 Fix merge. 42b46babe2 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_timeseries_emissions ce175b306e Merge pull request #1003 from NREL/output-variables 7c805d8ab5 Use timestep as the default. [ci skip] f5f4b6e7f2 Latest results. cc03c8f6b0 Fix bungled merge. 2ec5e44d6e Assume hourly timeseries when requesting output variables with no frequency specified. 664fa9defb Small refactor to avoid OS warning. f83c6c5ff1 Merge branch 'os340' of https://github.com/NREL/OpenStudio-HPXML into os340 1f1a90a4d0 Remove window warning. cb16f5501b Respond to review. 293b130fca Latest results. 12b17e5775 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_timeseries_emissions f3f16e8c42 Merge branch 'master' into output-variables 64ce5962b1 Merge branch 'master' into output-variables 7ceff7b7ea Clean up output variable reported names. 7b35be6d13 Merge branch 'master' into output-variables 69a9c0a21a Latest results. 37bc2e64d2 Latest results. a3b399b31e Latest results. f91651236a Replaces the final three instances of BeginTimestepBeforePredictor with BeginZoneTimestepAfterInitHeatBalance. Has a small impact for dehumidifiers, but no impact for the other two instances (HVAC grading and combi boilers). a8866728ab Fixes the whole house fan electricity timeseries output so that it's no longer off by 1 hour. Same as previous fix. 159c3f4301 Merge branch 'fix_timeseries_emissions' of https://github.com/NREL/OpenStudio-HPXML into fix_timeseries_emissions a8f007cc45 Changes infiltration program from BeginTimestepBeforePredictor calling point to BeginZoneTimestepAfterInitHeatBalance, which has almost no effect on heat transfer but fixes some timeseries outputs (like the mechanical ventilation component load). 26e1d8538c Latest results. d73203966e Some refactoring to consolidate electricity produced/net use code. ffecd8a461 Avoid need for shifting ec_adj timeseries output. Prevent combi boiler dhw_frac from being slightly greater than 1 for some hours. Prevent possible duplicate sql queries (faster performance). 8c2a8c6751 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_timeseries_emissions dd0b8b92a9 Fixes possibility of "Timeseries outputs (...) do not sum to annual output (...) for Emissions" error when using timeseries reporting frequency with an hourly timestep. Adds test. fda505a8d9 Update measure argument description. 5ea2342916 Update changelog and docs. a63142a44f Add reporting test for advanced output variables. f574c52e84 Add reporting test and update template osw. 18193edc88 Add new optional argument for output variables. git-subtree-dir: resources/hpxml-measures git-subtree-split: f492e9f0c43dec0f4c43b9d04dbc7877de0c9d98
joseph-robertson
added a commit
that referenced
this issue
Feb 3, 2023
…9b56438 5c0bd9b56438 Merge pull request #1012 from NREL/additional-properties-updates 8fa43c9bb448 Update Changelog.md 2569aeb17804 Minor cleanup. Reverts EPvalidator.xml and docs changes. 39032492560d Latest results. 5717b02e84a1 Merge branch 'master' into additional-properties-updates eab2693294df Update description and docs. a0176f01e5cb Merge pull request #1010 from NREL/fix_timeseries_emissions 15dc8bc1f0b0 Latest results. 3961f4dfd771 Update Changelog.md [ci skip] 6e981e11bc0a Latest results. c8ea2273a98e Test more characters. dea7fa60c414 Latest results. ddc83ef99c93 Merge branch 'master' into additional-properties-updates b5d2f37c644f Fixes and updates to tear down method. 63df131dbb14 Add convenience method for retrieving additional properties. git-subtree-dir: resources/hpxml-measures git-subtree-split: 5c0bd9b5643882c90654364a6fa3528b36cf6afd
joseph-robertson
added a commit
that referenced
this issue
Feb 3, 2023
…48fb6c9 9be6b48fb6c9 Merge pull request #1027 from NREL/foundation-floor-area fcb76b8aa1f0 Use new method throughout test. 89ecff3bb5e3 Add test for various foundations. 689cf5ff2086 Exclude garages from foundation floors. 62bf4d1d56ef Foundation slab could be at grade. d85026c649a1 Update the changelog. d7494630ba16 Update docs. c94657aa98f8 Update tests. cc7aa49ba455 Add new multiplier to measure and constants. 5c0bd9b56438 Merge pull request #1012 from NREL/additional-properties-updates 8fa43c9bb448 Update Changelog.md 2569aeb17804 Minor cleanup. Reverts EPvalidator.xml and docs changes. 39032492560d Latest results. 5717b02e84a1 Merge branch 'master' into additional-properties-updates eab2693294df Update description and docs. a0176f01e5cb Merge pull request #1010 from NREL/fix_timeseries_emissions 15dc8bc1f0b0 Latest results. 3961f4dfd771 Update Changelog.md [ci skip] 6e981e11bc0a Latest results. c8ea2273a98e Test more characters. dea7fa60c414 Latest results. ddc83ef99c93 Merge branch 'master' into additional-properties-updates b5d2f37c644f Fixes and updates to tear down method. 63df131dbb14 Add convenience method for retrieving additional properties. git-subtree-dir: resources/hpxml-measures git-subtree-split: 9be6b48fb6c978358cc8e942001ac2b2a9586eae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
resstock/project_testing/housing_characteristics/Solar Hot Water.tsv
Line 9 in ee49ad6
this seems to have propagated into the metadata files of the End Use Savings Shapes
The text was updated successfully, but these errors were encountered: