-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update numpy req to 2 #1051
base: develop
Are you sure you want to change the base?
Update numpy req to 2 #1051
Conversation
I'm OK with going up to |
May be you could check it works with numpy 2 (and fix incompatibilities if necessary) but set numpy requirement to Dependencies with |
Here is another problem with requirement I think there will be more difficulties for the majority of users if you do not upgrade to numpy 2.x than if you upgrade to numpy 2.x |
Some things to consider:
|
Ok, I think we're in agreement that we should make the move up to numpy 2, but after some discussions we'd like to do things in particular order. I will open a separate discussion to track the sequence (#1056) |
Update numpy req to 2
Testing an update based on #1030 where the numpy requirement is pushed up to compatiable version of 2.0.
An alternative approach would be to span version 1 and 2 using > and < operators, but I understand this to be non-preferred in semantic versioning, since testing would only apply to newer major version, and so the previous major version is not truly supported.
Using this PR also to check if having the requirement at ~=2.0 raises any incompatibilities.
Related issue
#1030