Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cf input to tidal turbine design page #1872

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

mjprilliman
Copy link
Collaborator

Description

-Expose target capacity factor input for tidal turbine design feature
-Was previously an assumed 30%
-See #1807 for context of this and what was added in patch 2
-See NREL/ssc#1218 for ssc

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjprilliman Should this new input variable in the UI be named tidal_turbine_target_cf with the label "Target capacity factor" to avoid confusion with the capacity factor output?

@mjprilliman
Copy link
Collaborator Author

@mjprilliman Should this new input variable in the UI be named tidal_turbine_target_cf with the label "Target capacity factor" to avoid confusion with the capacity factor output?

Yes that's a great point. I will clean this up.

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable name and label changes look good.

@cpaulgilman
Copy link
Collaborator

@mjprilliman Could you add a short description here of how the target capacity factor input works that I can use as a basis for Help documentation?

@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Oct 8, 2024
@cpaulgilman
Copy link
Collaborator

@mjprilliman Could you add a short description here of how the target capacity factor input works that I can use as a basis for Help documentation?

Thank you for emailing the description.

@mjprilliman mjprilliman merged commit 30a8329 into develop Oct 23, 2024
8 checks passed
@mjprilliman mjprilliman deleted the tidal-turbine-cf branch October 23, 2024 01:37
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Nov 21, 2024
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release enhancement marine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants