Tidal turbine power curve generation #1807
Conversation
There was a problem hiding this comment.
The functionality looks good.
When I choose the option to design the tidal converter, I see both the tidal design inputs and the inputs for the “choose tidal converter from library” option. The power curve table is technically disabled, but it is so prominent that I think most users will not know to ignore it, in spite of the red text at the top of the page. I think this should be set up like a battery dispatch page where the radio buttons are in a separate top panel and control what appears in the bottom panel.
I can't replicate this. When I switch to the tidal turbine design I only see the design page. |
|
@cpaulgilman Are you testing this on a Mac? I'm noticing the mac and Linux tests failing on SAM here (although only the pull_request) and I wanted to make sure there's not any differences across platforms. Also are you checking out the same branch name in ssc (NREL/ssc#1181)? |
|
@mjprilliman The distinguishing feature seems to be that the pull request builds are failing and the push builds are passing. The pull request builds are building against patch of ssc:
which seems incorrect in this case. I think it's safe to ignore it in this case and @dguittet and I can double check the CI scripts to fix this in the future. |
Thanks. I was looking for this yesterday but was looking in the wrong place. I had to rebase these branches to patch (manually, not using the git rebase command) if that is helpful in troubleshooting the CI. |
|
Ok I think the issue is that the PR workflow should also use the related ssc branch if it's available. I'll make that change. |
There was a problem hiding this comment.
Looks good. In my previous review, I did not link this with NREL/ssc#1181.
This requires a documentation update, which I will note for the Fall 2024 release.
cpaulgilman
added
the
added to release notes
Grid limits do not affect electricity imports from the grid. Revise IPH molten salt linear Fresnel topics Power tower heliostast pivot point height definition. New Financial Parameters topic for LCOH Calculator. Wind wake loss inputs NREL/ssc#1186 Annual energy and monthly energy label updates: NREL/ssc#1236 Replace parentheses with commas for installation cost units Battery availability loss. NREL/ssc#1241 Tidal Energy Converter page revisions for new options, see #1807. New net billing with carryover options. NREL/ssc#1200 IPH MSLF revisions: #1444 Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf. PV GCR affects output for bifacial modules. Revise report generator topic to explain template not available for some configurations. Add topics for IPH financial models Generic system to custom generatio profile Standalone battery time step New autographs and default graphs for battery configurations: #1884 System Availability three hour option for marine, "hourly" to "time series" ## October 24, 2024 Update Cambium note about years for Cambium 2023 Battery dispatch (BTM and FOM) battery can charge from grid-limited system power Grid limits battery can charge from grid-limited system power Project with 100% debt results in IRR = NaN Revise real discount rate description Geothermal system availability losses Revise metrics topics to facilitate navigation. Revise weather file format to include CSV for wind Revise PV subhourly clipping "Allen method" Revise Cost of Acquiring Financing.
* Help revisions for SAM 2024.12.12 Grid limits do not affect electricity imports from the grid. Revise IPH molten salt linear Fresnel topics Power tower heliostast pivot point height definition. New Financial Parameters topic for LCOH Calculator. Wind wake loss inputs NREL/ssc#1186 Annual energy and monthly energy label updates: NREL/ssc#1236 Replace parentheses with commas for installation cost units Battery availability loss. NREL/ssc#1241 Tidal Energy Converter page revisions for new options, see #1807. New net billing with carryover options. NREL/ssc#1200 IPH MSLF revisions: #1444 Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf. PV GCR affects output for bifacial modules. Revise report generator topic to explain template not available for some configurations. Add topics for IPH financial models Generic system to custom generatio profile Standalone battery time step New autographs and default graphs for battery configurations: #1884 System Availability three hour option for marine, "hourly" to "time series" ## October 24, 2024 Update Cambium note about years for Cambium 2023 Battery dispatch (BTM and FOM) battery can charge from grid-limited system power Grid limits battery can charge from grid-limited system power Project with 100% debt results in IRR = NaN Revise real discount rate description Geothermal system availability losses Revise metrics topics to facilitate navigation. Revise weather file format to include CSV for wind Revise PV subhourly clipping "Allen method" Revise Cost of Acquiring Financing. * Help revisions Revise "receiver startup delay time" and "receiver startup delay energy fraction" descriptions for trough and Fresnel models. Fix remaining references to "generic system" model. --------- Co-authored-by: Steven Janzou <[email protected]>
Description
-Modify ssc equation generating tidal turbine power curves to have rated power based on capacity factor calculations rather than an input power
-Show calculated power per rotor
-For patch 2, using a fixed capacity factor of 0.3 in ssc; for release expose capacity factor as an additional UI input
-todo for release: rename UI variables for improved clarity.
-See email for test materials
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.