Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heating energy calculation and reporting errors for gas fired and exhaust fired absorption chillerheater models #8645

Merged
merged 7 commits into from
Mar 26, 2021
Merged

Fix heating energy calculation and reporting errors for gas fired and exhaust fired absorption chillerheater models #8645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cf9876
Fix exhaust fired absorption chillerheater model heating energy calcu…
jcyuan2020 Mar 23, 2021
7eb3ad6
Add unit test.
jcyuan2020 Mar 23, 2021
e126ac1
A minor change in unit test.
jcyuan2020 Mar 24, 2021
f7135cd
Set avaiabile heat to zero fail safe in insufficient capacity case.
jcyuan2020 Mar 25, 2021
39e7efc
Apply the same fix to the gas fired absorption chiller heater twin.
jcyuan2020 Mar 25, 2021
9c46976
Add another unit test for the gas fired absorption chiller heater.
jcyuan2020 Mar 25, 2021
3decdc6
Make the test functions names consistent.
jcyuan2020 Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/EnergyPlus/ChillerExhaustAbsorption.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1888,7 +1888,13 @@ namespace EnergyPlus::ChillerExhaustAbsorption {
}

// Calculate operating part load ratio for cooling
lHeatPartLoadRatio = lHeatingLoad / lAvailableHeatingCapacity;
if (lAvailableHeatingCapacity <= 0.0) {
lAvailableHeatingCapacity = 0.0;
lHeatPartLoadRatio = 0.0;
} else
{
Comment on lines +1894 to +1895
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change to protect against divide by zero here and in the next chiller.
Minor formatting issue here, but that will get cleaned up with a global clang format sweep, so not holding this up for that.

lHeatPartLoadRatio = lHeatingLoad / lAvailableHeatingCapacity;
}

// Calculate ThermalEnergy consumption for heating
// ThermalEnergy used for heating availCap * HIR * HIR-FT * HIR-FPLR
Expand Down
7 changes: 6 additions & 1 deletion src/EnergyPlus/ChillerGasAbsorption.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1803,7 +1803,12 @@ namespace EnergyPlus::ChillerGasAbsorption {
}

// Calculate operating part load ratio for cooling
lHeatPartLoadRatio = lHeatingLoad / lAvailableHeatingCapacity;
if (lAvailableHeatingCapacity <= 0.0) {
lAvailableHeatingCapacity = 0.0;
lHeatPartLoadRatio = 0.0;
} else {
lHeatPartLoadRatio = lHeatingLoad / lAvailableHeatingCapacity;
}

// Calculate fuel consumption for cooling
// fuel used for cooling availCap * HIR * HIR-FT * HIR-FPLR
Expand Down
Loading