-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix heating energy calculation and reporting errors for gas fired and exhaust fired absorption chillerheater models #8645
Fix heating energy calculation and reporting errors for gas fired and exhaust fired absorption chillerheater models #8645
Conversation
a33e70d
to
e521557
Compare
2046d50
to
7387807
Compare
7387807
to
3decdc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the defect file before and after:
develop debug build crashes.
develop release build has NANs in BEPS.
this branch debug build completes without NANs.
} else | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward change to protect against divide by zero here and in the next chiller.
Minor formatting issue here, but that will get cleaned up with a global clang format sweep, so not holding this up for that.
Not waiting any longer for CI to finish, merging. |
Pull request overview
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.
If feature, test running new feature, try creative ways to break itCheck any new function arguments for performance impactsVerify IDF naming conventions and styles, memos and notes and defaultsIf new idf included, locally check the err file and other outputs