Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heating energy calculation and reporting errors for gas fired and exhaust fired absorption chillerheater models #8645

Merged

Conversation

jcyuan2020
Copy link
Contributor

@jcyuan2020 jcyuan2020 commented Mar 23, 2021

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Mar 23, 2021
@mjwitte mjwitte added this to the EnergyPlus 9.5.0 milestone Mar 23, 2021
@jcyuan2020 jcyuan2020 force-pushed the Exhaust_Absorption_ChillerHeater_Model_Fix branch from a33e70d to e521557 Compare March 24, 2021 00:01
@jcyuan2020 jcyuan2020 marked this pull request as ready for review March 24, 2021 00:05
@jcyuan2020 jcyuan2020 force-pushed the Exhaust_Absorption_ChillerHeater_Model_Fix branch 8 times, most recently from 2046d50 to 7387807 Compare March 25, 2021 21:16
@jcyuan2020 jcyuan2020 changed the title Fix exhaust fired absorption chillerheater model heating energy calculation and reporting errors Fix heating energy calculation and reporting errors for gas fired and exhaust fired absorption chillerheater models Mar 25, 2021
@jcyuan2020 jcyuan2020 force-pushed the Exhaust_Absorption_ChillerHeater_Model_Fix branch from 7387807 to 3decdc6 Compare March 26, 2021 03:41
Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the defect file before and after:
develop debug build crashes.
develop release build has NANs in BEPS.
this branch debug build completes without NANs.

Comment on lines +1894 to +1895
} else
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change to protect against divide by zero here and in the next chiller.
Minor formatting issue here, but that will get cleaned up with a global clang format sweep, so not holding this up for that.

@mjwitte
Copy link
Contributor

mjwitte commented Mar 26, 2021

Not waiting any longer for CI to finish, merging.

@mjwitte mjwitte merged commit f56b20e into NREL:develop Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heating report value NaN problem due to exhaust fired absorption chillerheater model floating point errors
7 participants