-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global DataPlant plus a few other PlantComponents #8457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n how this is applied in SetpointManager
mitchute
added
the
Refactoring
Includes code changes that don't change the functionality of the program, just perform refactoring
label
Jan 8, 2021
Excellent. OK, thanks for cleaning this PR so it's all green. That is confirmation of that issue in the code, so I'm excited to deal with that separately. If anyone has merge issues with these changes, just message me and I can pull your branch and resolve the issues and push it back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Refactoring
Includes code changes that don't change the functionality of the program, just perform refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Expects diffs due to Scheduled TES SetPointManager OpMode flags do not match OpMode flags in PlantCondLoopOperation #8452I'll deal with this in a separate PR to keep this one diff-free.Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.