Scheduled TES SetPointManager OpMode flags do not match OpMode flags in PlantCondLoopOperation

[mitchute]

Issue overview

While working on more global state refactoring, I was moving the OpMode int const flags to an enum class.

EnergyPlus/src/EnergyPlus/PlantCondLoopOperation.cc

Lines 113 to 115 in 637ea91

	int const HeatingOp(1); // Constant for Heating Operation
	int const CoolingOp(2); // Constant for Cooling Operation
	int const DualOp(3); // Constant for Cooling or Heating Operation

In doing so, I discovered that they were being compared against similar int const flags in SetPointManager.

EnergyPlus/src/EnergyPlus/SetPointManager.cc

Lines 5048 to 5049 in 637ea91

	int const CoolOpComp(1); // a component that cools only (chillers)
	int const DualOpComp(2); // a component that heats or cools (ice storage tank)

However, the values do not line up between the two separate sets of int flags. I've fixed the bug locally in my branch, here, but I could also get this part merged in to develop before merging my next global PR.

Details

Some additional details for this issue (if relevant):

• Version of EnergyPlus (9.4.0 - 637ea91)

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)