Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfinished FuelCellElectricGenerator Unit Test #8492

Closed
1 of 2 tasks
mitchute opened this issue Jan 29, 2021 · 0 comments · Fixed by #8511
Closed
1 of 2 tasks

Unfinished FuelCellElectricGenerator Unit Test #8492

mitchute opened this issue Jan 29, 2021 · 0 comments · Fixed by #8511
Assignees
@jmarrec
Labels
Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog

Comments

@mitchute
Copy link
Collaborator

mitchute commented Jan 29, 2021 •
edited by jmarrec
Loading

Issue overview

The FuelCellElectricGenerator unit test is unfinished.

https://github.com/NREL/EnergyPlus/blob/18f1ce3d49ae10de396d35cb18ceb0735c93e9c8/tst/EnergyPlus/unit/FuelCellElectricGenerator.unit.cc

Someone should flesh this out so that it at least processes the input.

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of EnergyPlus (if using an intermediate build, include SHA): 9.4+, 18f1ce3

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@mitchute mitchute added Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog labels Jan 29, 2021
@jmarrec jmarrec self-assigned this Feb 5, 2021
@jmarrec jmarrec mentioned this issue Feb 5, 2021
Merged
20 tasks
dareumnam added a commit that referenced this issue Mar 2, 2021
@dareumnam
Merge pull request #8511 from NREL/8492_FuellCell_Test
3d14610 
#8492 #8513 - Add a FuelCellElectricGenerator Unit Test and do not zero out Constant Skin Loss Rate in Generator:FuelCell:PowerModule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Milestone
No milestone
2 participants
@mitchute @jmarrec