Skip to content

Commit

Permalink
Merge pull request #8479 from NREL/PlantCompRefactor2
Browse files Browse the repository at this point in the history 
Plant Cleanups
  • Loading branch information
@mitchute
mitchute authored Feb 4, 2021
2 parents 0fad38d + 7912a9a commit 18f1ce3
Show file tree
Hide file tree
Showing 32 changed files with 1,540 additions and 1,690 deletions.
170 changes: 85 additions & 85 deletions src/EnergyPlus/BoilerSteam.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,87 @@ namespace BoilerSteam {
}
}

void BoilerSpecs::oneTimeInit(EnergyPlusData &state) {
bool errFlag = false;
PlantUtilities::ScanPlantLoopsForObject(state,
this->Name,
DataPlant::TypeOf_Boiler_Steam,
this->LoopNum,
this->LoopSideNum,
this->BranchNum,
this->CompNum,
errFlag,
_,
_,
_,
_,
_);
if (errFlag) {
ShowFatalError(state, "InitBoiler: Program terminated due to previous condition(s).");
}
}

void BoilerSpecs::initEachEnvironment(EnergyPlusData &state) {
static std::string const RoutineName("BoilerSpecs::initEachEnvironment");

int BoilerInletNode = this->BoilerInletNodeNum;

Real64 EnthSteamOutDry =
FluidProperties::GetSatEnthalpyRefrig(state, fluidNameSteam, this->TempUpLimitBoilerOut, 1.0, this->FluidIndex, RoutineName);
Real64 EnthSteamOutWet =
FluidProperties::GetSatEnthalpyRefrig(state, fluidNameSteam, this->TempUpLimitBoilerOut, 0.0, this->FluidIndex, RoutineName);
Real64 LatentEnthSteam = EnthSteamOutDry - EnthSteamOutWet;

Real64 CpWater =
FluidProperties::GetSatSpecificHeatRefrig(state, fluidNameSteam, this->TempUpLimitBoilerOut, 0.0, this->FluidIndex, RoutineName);

this->DesMassFlowRate =
this->NomCap / (LatentEnthSteam + CpWater * (this->TempUpLimitBoilerOut - DataLoopNode::Node(BoilerInletNode).Temp));

PlantUtilities::InitComponentNodes(0.0,
this->DesMassFlowRate,
this->BoilerInletNodeNum,
this->BoilerOutletNodeNum,
this->LoopNum,
this->LoopSideNum,
this->BranchNum,
this->CompNum);

this->BoilerPressCheck = 0.0;
this->FuelUsed = 0.0;
this->BoilerLoad = 0.0;
this->BoilerEff = 0.0;
this->BoilerOutletTemp = 0.0;

if ((DataLoopNode::Node(this->BoilerOutletNodeNum).TempSetPoint == DataLoopNode::SensedNodeFlagValue) &&
(DataLoopNode::Node(this->BoilerOutletNodeNum).TempSetPointLo == DataLoopNode::SensedNodeFlagValue)) {
if (!state.dataGlobal->AnyEnergyManagementSystemInModel) {
if (!this->MissingSetPointErrDone) {
ShowWarningError(state, "Missing temperature setpoint for Boiler:Steam = " + this->Name);
ShowContinueError(state, " A temperature setpoint is needed at the outlet node of the boiler, use a SetpointManager");
ShowContinueError(state, " The overall loop setpoint will be assumed for this boiler. The simulation continues ...");
this->MissingSetPointErrDone = true;
}
} else {
// need call to EMS to check node
bool FatalError = false; // but not really fatal yet, but should be.
EMSManager::CheckIfNodeSetPointManagedByEMS(state, this->BoilerOutletNodeNum, EMSManager::SPControlType::iTemperatureSetPoint, FatalError);
DataLoopNode::NodeSetpointCheck(this->BoilerOutletNodeNum).needsSetpointChecking = false;
if (FatalError) {
if (!this->MissingSetPointErrDone) {
ShowWarningError(state, "Missing temperature setpoint for LeavingSetpointModulated mode Boiler named " + this->Name);
ShowContinueError(state, " A temperature setpoint is needed at the outlet node of the boiler.");
ShowContinueError(state, " Use a Setpoint Manager to establish a setpoint at the boiler outlet node ");
ShowContinueError(state, " or use an EMS actuator to establish a setpoint at the boiler outlet node.");
ShowContinueError(state, " The overall loop setpoint will be assumed for this boiler. The simulation continues...");
this->MissingSetPointErrDone = true;
}
}
}
this->UseLoopSetPoint = true; // this is for backward compatibility and could be removed
}
}

void BoilerSpecs::initialize(EnergyPlusData &state) // number of the current electric chiller being simulated
{
// SUBROUTINE INFORMATION:
Expand All @@ -307,99 +388,17 @@ namespace BoilerSteam {
// METHODOLOGY EMPLOYED:
// Uses the status flags to trigger initializations.

// SUBROUTINE PARAMETER DEFINITIONS:
static std::string const RoutineName("InitBoiler");

// Init more variables
if (this->myFlag) {
// setup output variables once here
this->setupOutputVars(state);
// Locate the chillers on the plant loops for later usage
bool errFlag = false;
PlantUtilities::ScanPlantLoopsForObject(state,
this->Name,
DataPlant::TypeOf_Boiler_Steam,
this->LoopNum,
this->LoopSideNum,
this->BranchNum,
this->CompNum,
errFlag,
_,
_,
_,
_,
_);
if (errFlag) {
ShowFatalError(state, "InitBoiler: Program terminated due to previous condition(s).");
}

this->oneTimeInit(state);
this->myFlag = false;
}

int BoilerInletNode = this->BoilerInletNodeNum;
int BoilerOutletNode = this->BoilerOutletNodeNum;

if (state.dataGlobal->BeginEnvrnFlag && this->myEnvrnFlag && (state.dataPlnt->PlantFirstSizesOkayToFinalize)) {

Real64 EnthSteamOutDry =
FluidProperties::GetSatEnthalpyRefrig(state, fluidNameSteam, this->TempUpLimitBoilerOut, 1.0, this->FluidIndex, RoutineName);
Real64 EnthSteamOutWet =
FluidProperties::GetSatEnthalpyRefrig(state, fluidNameSteam, this->TempUpLimitBoilerOut, 0.0, this->FluidIndex, RoutineName);
Real64 LatentEnthSteam = EnthSteamOutDry - EnthSteamOutWet;

Real64 CpWater =
FluidProperties::GetSatSpecificHeatRefrig(state, fluidNameSteam, this->TempUpLimitBoilerOut, 0.0, this->FluidIndex, RoutineName);

this->DesMassFlowRate =
this->NomCap / (LatentEnthSteam + CpWater * (this->TempUpLimitBoilerOut - DataLoopNode::Node(BoilerInletNode).Temp));

PlantUtilities::InitComponentNodes(0.0,
this->DesMassFlowRate,
this->BoilerInletNodeNum,
this->BoilerOutletNodeNum,
this->LoopNum,
this->LoopSideNum,
this->BranchNum,
this->CompNum);

this->BoilerPressCheck = 0.0;
this->FuelUsed = 0.0;
this->BoilerLoad = 0.0;
this->BoilerEff = 0.0;
this->BoilerOutletTemp = 0.0;

if ((DataLoopNode::Node(this->BoilerOutletNodeNum).TempSetPoint == DataLoopNode::SensedNodeFlagValue) &&
(DataLoopNode::Node(this->BoilerOutletNodeNum).TempSetPointLo == DataLoopNode::SensedNodeFlagValue)) {
if (!state.dataGlobal->AnyEnergyManagementSystemInModel) {
if (!this->MissingSetPointErrDone) {
ShowWarningError(state, "Missing temperature setpoint for Boiler:Steam = " + this->Name);
ShowContinueError(state, " A temperature setpoint is needed at the outlet node of the boiler, use a SetpointManager");
ShowContinueError(state, " The overall loop setpoint will be assumed for this boiler. The simulation continues ...");
this->MissingSetPointErrDone = true;
}
} else {
// need call to EMS to check node
bool FatalError = false; // but not really fatal yet, but should be.
EMSManager::CheckIfNodeSetPointManagedByEMS(state, this->BoilerOutletNodeNum, EMSManager::SPControlType::iTemperatureSetPoint, FatalError);
DataLoopNode::NodeSetpointCheck(this->BoilerOutletNodeNum).needsSetpointChecking = false;
if (FatalError) {
if (!this->MissingSetPointErrDone) {
ShowWarningError(state, "Missing temperature setpoint for LeavingSetpointModulated mode Boiler named " + this->Name);
ShowContinueError(state, " A temperature setpoint is needed at the outlet node of the boiler.");
ShowContinueError(state, " Use a Setpoint Manager to establish a setpoint at the boiler outlet node ");
ShowContinueError(state, " or use an EMS actuator to establish a setpoint at the boiler outlet node.");
ShowContinueError(state, " The overall loop setpoint will be assumed for this boiler. The simulation continues...");
this->MissingSetPointErrDone = true;
}
}
}
this->UseLoopSetPoint = true; // this is for backward compatibility and could be removed
}

this->initEachEnvironment(state);
this->myEnvrnFlag = false;

} // End If for the Begin Environment initializations

}
if (!state.dataGlobal->BeginEnvrnFlag) {
this->myEnvrnFlag = true;
}
Expand All @@ -408,6 +407,7 @@ namespace BoilerSteam {
// At some point, need to circle back and get from plant data structure instead of node
// fix for clumsy old input that worked because loop setpoint was spread.
// could be removed with transition, testing , model change, period of being obsolete.
int BoilerOutletNode = this->BoilerOutletNodeNum;
{
auto const SELECT_CASE_var(state.dataPlnt->PlantLoop(this->LoopNum).LoopDemandCalcScheme);
if (SELECT_CASE_var == DataPlant::iLoopDemandCalcScheme::SingleSetPoint) {
Expand Down
4 changes: 4 additions & 0 deletions src/EnergyPlus/BoilerSteam.hh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ namespace BoilerSteam {

void getSizingFactor(Real64 &sizFac) override;

void oneTimeInit(EnergyPlusData &state);

void initEachEnvironment(EnergyPlusData &state);

void onInitLoopEquip([[maybe_unused]] EnergyPlusData &state, [[maybe_unused]] const PlantLocation &calledFromLocation) override;

static PlantComponent *factory(EnergyPlusData &state, std::string const &objectName);
Expand Down
Loading

5 comments on commit 18f1ce3

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (2297 of 2297 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1558 of 1558 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - x86_64-MacOS-10.15-clang-11.0.0: OK (2277 of 2277 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - Win64-Windows-10-VisualStudio-16: Tests Failed (2 of 2250 tests passed, 0 test warnings)

Failures:\n

API Test Summary

  • Exit code 0xc0000135
    : 3
  • Failed: 1

integration Test Summary

  • Passed: 2
  • Failed: 717

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (722 of 722 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.