Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TRANSITION mode #2

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Remove TRANSITION mode #2

merged 1 commit into from
Sep 23, 2019

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 20, 2019 •
edited
Loading

Changes:

  • remove all code related to the deprecated TRANSITION mode for Theia+Intel15, affects stochy_patterngenerator.F90 only

For regression testing, see NCAR/NEMSfv3gfs#251

This was referenced Sep 22, 2019
Merged
Merged
Merged
Merged
@climbfuji
Copy link
Collaborator Author

Associated PRs:

https://github.com/NCAR/FV3/pull/207
NCAR/NEMS#10
https://github.com/NCAR/NEMSfv3gfs/pull/251
NCAR/ccpp-framework#225
NCAR/ccpp-physics#322
NCAR/GFDL_atmos_cubed_sphere#2
#2

@climbfuji climbfuji marked this pull request as ready for review September 22, 2019 14:05
@climbfuji climbfuji requested a review from pjpegion as a code owner September 22, 2019 14:05
@climbfuji
Copy link
Collaborator Author

@pjpegion this can be merged anytime, preferably before https://github.com/NCAR/NEMSfv3gfs/pull/251 is merged so that the follow-up submodule pointer update points to the latest version.

llpcarson
llpcarson approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@llpcarson llpcarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pjpegion
Copy link
Collaborator

Dom, Looks good. I will do the merge.

@pjpegion pjpegion merged commit 25c3321 into NOAA-PSL:master Sep 23, 2019
@climbfuji
Copy link
Collaborator Author

Thanks @pjpegion that was quick!

pjpegion added a commit that referenced this pull request Dec 6, 2019
@pjpegion
Merge pull request #2 from pjpegion/decomp_work
8b21af2 
Decomp work
DomHeinzeller referenced this pull request in NOAA-GSL/stochastic_physics Jan 9, 2021
@tanyasmirnova
Merge pull request #2 from climbfuji/more_cleanup_for_tanya
81d091f 
More cleanup for Tanya
climbfuji pushed a commit to climbfuji/stochastic_physics that referenced this pull request Jan 20, 2021
@DomHeinzeller
Merge pull request NOAA-PSL#2 from tanyasmirnova/gsl_stoch_zorl
b6c1262 
Add roughness length over land to the perturbed variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llpcarson llpcarson llpcarson approved these changes

@pjpegion pjpegion Awaiting requested review from pjpegion pjpegion is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@climbfuji @pjpegion @llpcarson