Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roughness length over land to the perturbed variables #2

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

tanyasmirnova
Copy link
Collaborator

The zorll variable is added to the perturbed land parameters.

@DomHeinzeller DomHeinzeller self-requested a review January 14, 2021 15:10
Copy link

@DomHeinzeller DomHeinzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty straightforward. We should think about conditionally allocating the arrays in FV3's stochastic_physics_wrapper and passing them as either optional arguments or with assumed size to lnd_apply_perts to reduce our memory footprint.

We will also need a ufs-weather-model PR that combines these changes and tests them. I can do that if you want me to.

@@ -294,7 +294,7 @@ subroutine compns_stochy (me,sz_nml,input_nml_file,fn_nml,nlunit,deltim,iret)
'land perturbations will be applied to selected paramaters, using newer scheme designed for DA ens spread'
do k =1,n_var_lndp
select case (lndp_var_list(k))
case('vgf','smc','stc','alb', 'sal','emi')
case('vgf','smc','stc','alb', 'sal','emi','zol','zoi','zow')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be just zol for the time being? I see that the code will stop anyway in lndp_apply_perts, so I think either way is fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. Sorry, forgot to remove them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DomHeinzeller Yes, it could be a very good change to allocate arrays conditionally.
I'll appreciate if you could do the ufs-weather-model PR. Thank you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the change in compns_stochy.F90 so that it reads and then push it to this PR?

case('vgf','smc','stc','alb','sal','emi','zol')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DomHeinzeller DomHeinzeller changed the title Added roughness length over land to the perturbed variables. Add roughness length over land to the perturbed variables Jan 16, 2021
@DomHeinzeller DomHeinzeller self-requested a review January 19, 2021 17:57
@DomHeinzeller DomHeinzeller merged commit b6c1262 into NOAA-GSL:gsl/develop Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants