Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boundary condition bug fixes and module_sf_ruclsm precision fix #150

Merged
merged 13 commits into from
Sep 28, 2022
Merged

boundary condition bug fixes and module_sf_ruclsm precision fix #150

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2f8f5a4
update FV3 hash
SamuelTrahanNOAA Sep 22, 2022
ac98153
120 second timestep in conus13km tests
SamuelTrahanNOAA Sep 22, 2022
890dc25
put conus13km debug tests in rt and rt_gnu confs
SamuelTrahanNOAA Sep 22, 2022
393dcbc
update baseline data
SamuelTrahanNOAA Sep 22, 2022
1c2ecf7
hera.gnu tests passed
SamuelTrahanNOAA Sep 23, 2022
5f63a81
hera intel tests
SamuelTrahanNOAA Sep 23, 2022
256066a
jet tests passed
SamuelTrahanNOAA Sep 23, 2022
f36823e
move snow sanity check to sanity check regions of lsm_ruc, and apply …
SamuelTrahanNOAA Sep 23, 2022
fc1a6ba
Merge remote branch.
SamuelTrahanNOAA Sep 23, 2022
9258eea
use i-1 & j-1 for two-point averages, when available
SamuelTrahanNOAA Sep 27, 2022
add6b90
point to RRFS_dev in FV3
SamuelTrahanNOAA Sep 28, 2022
209ea9d
fix name 13KM_RT => FV3_RT
SamuelTrahanNOAA Sep 28, 2022
3b7be57
merge test logs
SamuelTrahanNOAA Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FV3
Open in desktop
Submodule FV3 updated 2 files
+1 −1 atmos_cubed_sphere
+1 −1 ccpp/physics
544 changes: 288 additions & 256 deletions tests/RegressionTests_hera.gnu.log
View file
Open in desktop

Large diffs are not rendered by default.

1,496 changes: 764 additions & 732 deletions tests/RegressionTests_hera.intel.log
View file
Open in desktop

Large diffs are not rendered by default.

1,330 changes: 681 additions & 649 deletions tests/RegressionTests_jet.intel.log
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions tests/rt.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ RUN | regional_3km

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_RRTMGP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_HRRR_smoke,FV3_RRFS_v1beta,FV3_RRFS_v1nssl -D32BIT=ON -DDEBUG=ON | | fv3 |
RUN | hrrr_control_debug | | fv3 |
RUN | rrfs_conus13km_hrrr_warm_debug | | fv3 |
RUN | rrfs_conus13km_radar_tten_warm_debug | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_RRTMGP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_HRRR_smoke,FV3_RRFS_v1beta,FV3_RRFS_v1nssl -D32BIT=ON | | fv3 |

Expand Down
2 changes: 1 addition & 1 deletion tests/rt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ if [[ $TESTS_FILE =~ '35d' ]] || [[ $TESTS_FILE =~ 'weekly' ]]; then
TEST_35D=true
fi

BL_DATE=20220613
BL_DATE=20220922
if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]] || [[ $MACHINE_ID = gaea.* ]] || [[ $MACHINE_ID = jet.* ]] || [[ $MACHINE_ID = s4.* ]]; then
RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/RRFS_dev-${BL_DATE}/${RT_COMPILER^^}}
else
Expand Down
2 changes: 2 additions & 0 deletions tests/rt_gnu.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ RUN | control_p8

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_HRRR_smoke,FV3_RRFS_v1beta -D32BIT=ON -DDEBUG=ON | | fv3 |
RUN | hrrr_control_debug | | fv3 |
RUN | rrfs_conus13km_hrrr_warm_debug | | fv3 |
RUN | rrfs_conus13km_radar_tten_warm_debug | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_HRRR_smoke,FV3_RRFS_v1beta -D32BIT=ON | | fv3 |

Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_hrrr_warm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_hrrr_warm_2threads
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_hrrr_warm_debug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_hrrr_warm_decomp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_hrrr_warm_restart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export QUILTING=.true.
export WRITE_GROUP=1
export WRTTASK_PER_GROUP=6
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_radar_tten_warm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_radar_tten_warm_2threads
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_radar_tten_warm_debug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_radar_tten_warm_decomp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_conus13km_radar_tten_warm_restart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export QUILTING=.true.
export WRITE_GROUP=1
export WRTTASK_PER_GROUP=6
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_smoke_conus13km_hrrr_warm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_smoke_conus13km_hrrr_warm_2threads
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_smoke_conus13km_hrrr_warm_debug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_smoke_conus13km_hrrr_warm_decomp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export RESTART_INTERVAL=1
export QUILTING=.true.
export WRITE_GROUP=1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/rrfs_smoke_conus13km_hrrr_warm_restart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export SMONTH=5
export SDAY=12
export SHOUR=16
export FHMAX=2
export DT_ATMOS=60
export DT_ATMOS=120
export QUILTING=.true.
export WRITE_GROUP=1
export WRTTASK_PER_GROUP=6
Expand Down