boundary condition bug fixes and module_sf_ruclsm precision fix #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelTrahanNOAA
changed the title
SamuelTrahanNOAA
requested review from
haiqinli,
hannahcbarnes,
hu5970,
joeolson42,
tanyasmirnova,
zhanglikate and
mdtoyNOAA
hannahcbarnes
approved these changes
Sep 23, 2022
16 tasks
haiqinli
approved these changes
Sep 23, 2022
zhanglikate
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
@SamuelTrahanNOAA The better place for snow sanity check is in lsm_ruc.F90. It already has the "sanity check" but I guess it does not cover the situation when snow<1.e-20.
mdtoyNOAA
approved these changes
Sep 23, 2022
…to "snow on ice" as well. Hera gnu tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
Corrects many bugs in regional boundary condition generation, an imprecision issue in module_sf_ruclsm, adds the debug version of two conus13km tests, and changes the timestep from 60s to 120s in all conus13km tests.
This is a duplicate of the community PR, except that the 2threads test in this PR doesn't match its control:
ufs-community#1437
Nothing in this PR can affect threads, so there must be another difference between RRFS_dev and the authoritative branches that fixes 2threads support.
Issue(s) addressed
These are fixed:
NOAA-GFDL/GFDL_atmos_cubed_sphere#218
ufs-community/ccpp-physics#5
Half of this is fixed in develop (debug & 2threads), but only a quarter in RRFS_dev (debug only):
ufs-community#1222
These are newly-discovered bugs, for which this PR adds workarounds. The bugs should be fixed, and the workarounds removed:
NOAA-EMC/fv3atm#586
ufs-community#1436
Testing
See community PR.
Dependencies
atmos_cubed_sphere boundary condition fix: NOAA-GSL/GFDL_atmos_cubed_sphere#12
ccpp_physics precision fix: NOAA-GSL/ccpp-physics#163
fv3atm: NOAA-GSL/fv3atm#156