Rescale internal variables in reset_face_lengths_list #276
Conversation
Apply dimensional rescaling immediately after reading the open face width and porous barrier depth variables in reset_face_lengths_list to facilitate the detection of improperly scaled variables or incorrect unit declarations throughout the code. Also eliminated unnecessary local copies of rescaling factors in the MOM_porous_barriers module. All answers are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #276 +/- ##
============================================
- Coverage 37.10% 37.09% -0.01%
============================================
Files 263 263
Lines 73582 73586 +4
Branches 13718 13718
============================================
- Hits 27299 27294 -5
- Misses 41249 41257 +8
- Partials 5034 5035 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
These changes seem reasonable to me. It makes sense to perform the MOM_porous_barriers in Z rather than eta (especially since Z_to_eta was hardcoded to 1.0 anyway. Great that that is removed).
The changes to reset_face_lengths_list() are also reasonable. Much cleaner to rescale the variables at read-in than during the calculations.
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17781 ✔️ |
|
Approved on behalf of @sditkovsky |
Apply dimensional rescaling immediately after reading the open face width and porous barrier depth variables in reset_face_lengths_list() to facilitate the detection of improperly scaled variables or incorrect unit declarations throughout the code. Also eliminated unnecessary local copies of rescaling factors in the MOM_porous_barriers module. All answers are bitwise identical.