+Add set_initialized #152
Merged
+Add set_initialized #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the overloaded interface set_initialized() to the MOM_restart module, to record that fields have been initialized, despite not appearing in a restart file. This will allow for a second call to set_initialized() after a call to query_initialized() to replicate the existing behavior of query_initialized() after MOM6 PR mom-ocean#149 (NOAA-GFDL#149) has been accepted. All answers are bitwise identical, but there is a new public interface.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #152 +/- ##
============================================
+ Coverage 34.05% 34.23% +0.18%
============================================
Files 259 257 -2
Lines 70126 69802 -324
Branches 12984 12928 -56
============================================
+ Hits 23879 23897 +18
+ Misses 41753 41431 -322
+ Partials 4494 4474 -20
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16055 ✔️ I did not see any case where this was used, but I assume that is for a future PR. |
marshallward
approved these changes
Jul 5, 2022
Hallberg-NOAA
added a commit
to Hallberg-NOAA/MOM6
that referenced
this pull request
Jul 18, 2022
Call set_initialized for variables after they are initialized, when their lack of initialization was detected via query_initialized. This commit reproduces the model's behavior prior to the removal of the code that set the initialized flag within query_initialized in NOAA-GFDL#149, and it completes the set of changes that was envisioned when set_initialized was added in NOAA-GFDL#152. All answers are bitwise identical.
marshallward
pushed a commit
that referenced
this pull request
Jul 26, 2022
Call set_initialized for variables after they are initialized, when their lack of initialization was detected via query_initialized. This commit reproduces the model's behavior prior to the removal of the code that set the initialized flag within query_initialized in #149, and it completes the set of changes that was envisioned when set_initialized was added in #152. All answers are bitwise identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the overloaded interface set_initialized() to the MOM_restart module, to
record that fields have been initialized, despite not appearing in a restart
file. This will allow for a second call to set_initialized() after a call to
query_initialized() to replicate the existing behavior of query_initialized()
after MOM6 PR #149 (#149) has been
accepted. All answers are bitwise identical, but there is a new public
interface.